Closed Bug 1996952 Opened 6 months ago Closed 3 months ago

Bake the M4 experiment Merino OHTTP endpoints into Nightly

Categories

(Firefox :: Address Bar, task, P1)

task

Tracking

()

RESOLVED FIXED
149 Branch
Tracking Status
firefox149 --- fixed

People

(Reporter: nanj, Assigned: adw)

References

Details

(Whiteboard: [sng])

Attachments

(1 file)

We have finalized various endpoints for the Fastly OHTTP Relay and our OHTTP Gateway:

  • Relay endpoint:

    • Pref: "browser.urlbar.merino.ohttpRelayURL"
    • stage: https://ohttp-merino-stage.mozilla.fastly-edge.com
    • prod: https://ohttp-merino.mozilla.fastly-edge.com
  • OHTTP config endpoint:

    • Pref: "browser.urlbar.merino.ohttpConfigURL"
    • prod: https://merino.services.mozilla.com/api/v1/suggest/ohttp-configs
  • The Merino suggest endpoint remained unchanged

    • Pref: "browser.urlbar.merino.endpointURL"
    • prod: https://merino.services.mozilla.com/api/v1/suggest

The production endpoints can be baked into m-c as the default values for Merino's OHTTP prefs now.

Note:

  • The OHTTP config prod endpoint will be available soon once we migrate Merino from v1 to v2.
  • The Nimbus variables for those prefs can be kept to facilitate future rollouts & experimentation.
Severity: -- → N/A
Priority: -- → P2
Whiteboard: [sng]

Thanks Nan! To add more in case it's not obvious to readers of this bug -- and please correct me if I'm misunderstanding:

We'll want to make a client code change for this only after 146, in whichever release where we're ready to roll out OHTTP to all online users. Until then, we can use the relevant Nimbus variables (as Nan said).

I'll move this to bug 1996166 so it's clearer that this is not a requirement for the initial client changes in 146.

Blocks: 1996166
No longer blocks: 1995336
Blocks: 1998008
No longer blocks: 1996166
Assignee: nobody → adw
Status: NEW → ASSIGNED
Priority: P2 → P1
Attachment #9541533 - Attachment description: Bug 1996952 - Bake Merino OHTTP endpoints into m-c. → Bug 1996952 - Bake the M4 experiment Merino OHTTP endpoints into Nightly.

We ended up landing the M4 ohttp endpoints right now, and for Nightly only, so I'll resummarize this bug. I probably should have attached the patch to a new bug and kept this one open, oh well.

From https://phabricator.services.mozilla.com/D281320#9778620:

Offline discussion with Nan: Infra isn't ready for Nightly users to hit the final ohttp endpoints quite yet, but to unblock this patch and D281321, we can use the M4 experiment endpoints temporarily. We want to make sure those endpoints don't ride the trains; they should remain Nightly only. So, this diff has some #ifdef NIGHTLY_BUILD guards.

I'll file a follow-up for updating the endpoints to the final URLs.

Summary: Bake Merino OHTTP endpoints into M-C → Bake the M4 experiment Merino OHTTP endpoints into Nightly
See Also: → 2015209
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 149 Branch
QA Whiteboard: [search] [qa-triage-done-c149/b148]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: