Closed
Bug 199701
Opened 22 years ago
Closed 22 years ago
GIF decoder index guard
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: tor, Assigned: tor)
Details
Attachments
(1 file, 2 obsolete files)
|
1.38 KB,
patch
|
paper
:
review+
blizzard
:
superreview+
|
Details | Diff | Splinter Review |
Currently we don't check to make sure the indices in the row buffer
are in the range of the colormap. This should be done to protect against
corrupted gifs.
Attachment #118796 -
Attachment is obsolete: true
Attachment #118797 -
Flags: review?(paper)
|
||
Comment 3•22 years ago
|
||
Comment on attachment 118797 [details] [diff] [review]
oops
ooh, can't pass up a chance to nitpick tor. ;)
+ max_index = gs->local_colormap_size-1;
Could we get spaces around the minux (and for the other one too)?
Other than that, good. :)
Attachment #118797 -
Flags: review?(paper) → review+
|
|
||
Comment 4•22 years ago
|
||
What I'd give for an edit button.
s/minux/minus/
Attachment #118797 -
Attachment is obsolete: true
Attachment #118951 -
Flags: superreview?(blizzard)
Attachment #118951 -
Flags: review?(paper)
|
|
||
Updated•22 years ago
|
Attachment #118951 -
Flags: review?(paper) → review+
|
||
Comment 6•22 years ago
|
||
Comment on attachment 118951 [details] [diff] [review]
Now with extra whitespace...
sr=blizzard
Attachment #118951 -
Flags: superreview?(blizzard) → superreview+
Checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•