1997102 - Remove support for non-oauth based login flows

Status: RESOLVED FIXED

(Firefox :: Firefox Accounts, enhancement)

Description

[Mark Hammond [:markh] [:mhammond]]

I think we should remove non-oauth support from Desktop. It is never used for real, so is only going to go stale and not work in practice. New capabilities we are adding will almost certainly not work too. A patch to remove this ends up removing around 1600 LOC, all of which just serve to confuse because it's not immediately clear they aren't used.

There is a risk that some things still try and use non-oauth - eg, maybe things like TPS. This is going to suck and we should fix them, but the fact remains that this is going to be broken over time regardless, so we might as well be clear that it's not supported.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1997102 - Remove support for non-oauth based login flows. r=skhamis

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5cf8e7214a2e
https://hg.mozilla.org/integration/autoland/rev/d3c2529cec00
Remove support for non-oauth based login flows. r=skhamis,credential-management-reviewers,fxview-reviewers,sync-reviewers,omc-reviewers,emcminn,dimi

Comment 3

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/d3c2529cec00