1997127 - [toolbar redesign] Hide new tab and tab counter in tab strip when toolbar redesign is enabled

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, task)

Description

[Rhodwell Malicdem [:RJ]]

Currently, simple toolbar shortcuts are hidden when tab strip is enabled, since the only option was the new tab and we wanted to avoid duplicates. With the new shortcut options being added, we want them to remain available even with the tab strip enabled. From discussion with UX, they decided to move the new tab and tab counter into the toolbar area when toolbar redesign is enabled.

Figma design

Comment 1

[Rhodwell Malicdem [:RJ]]

Attachment: Bug 1997127 - Hide tab strip buttons and show end-browser buttons when composable toolbar enabled

Comment 2

[Rhodwell Malicdem [:RJ]]

We’ll only show the tab strip buttons when the composable toolbar isn’t enabled. Using the toolbar redesign/customization flags would mean adding those to BrowserToolbarMiddleware and creating new tests, which isn’t worth it since that code is going away later.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7331a2f87d19
https://hg.mozilla.org/integration/autoland/rev/68329524306f
Hide tab strip buttons and show end-browser buttons when composable toolbar enabled r=android-reviewers,Roger

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/68329524306f