Closed
Bug 1997143
Opened 7 months ago
Closed 7 months ago
The in-tree langpack RPMs wrongly rename the langpack XPI
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(firefox146 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox146 | --- | fixed |
People
(Reporter: eijebong, Assigned: eijebong)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Firefox expects XPIs in distributions/extensions to have the same name as their ID or it throws errors like this:
Failed to install distribution add-on /usr/lib/firefox-nightly/distribution/extensions/langpack-it@firefox-nightly.mozilla.org.xpi: Error: File file /usr/lib/firefox-nightly/distribution/extensions/langpack-it@firefox-nightly.mozilla.org.xpi contains an add-on with an incorrect ID(resource://gre/modules/addons/XPIInstall.sys.mjs:4187:13) JS Stack trace: installDistributionAddon@XPIInstall.sys.mjs:4187:13
awaitPromise@XPIProvider.sys.mjs:237:15
|
Assignee | |
Comment 1•7 months ago
|
||
Firefox expects XPI files in distribution/extensions to be named with
their ID or it throws exceptions on startup like
/usr/lib/firefox-nightly/distribution/extensions/langpack-it@firefox-nightly.mozilla.org.xpi contains an add-on with an incorrect ID.
The previous code would use the package name but the langpack XPI ID is
actually using the remoting name (firefox/devedition) and does not
contain the track for which it was built. So we ended up with
langpack-fr@firefox-nightly.mozilla.org.xpi instead of
langpack-fr@firefox.mozilla.org.xpi for nightly builds (same issue
with beta), which prevents the langpack from loading.
Pushed by borivel@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/4533a2607969
https://hg.mozilla.org/integration/autoland/rev/50f30829d663
Properly name XPI files in the langpack RPM packages. r=releng-reviewers,jcristau
|
||
Comment 3•7 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
status-firefox146:
--- → fixed
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•