Closed
Bug 1997148
Opened 8 months ago
Closed 3 months ago
Provide access to the NavController from within the PlayStoreReviewPromptController
Categories
(Firefox for Android :: Experimentation and Telemetry, task)
Tracking
()
RESOLVED
FIXED
151 Branch
| Tracking | Status | |
|---|---|---|
| firefox151 | --- | fixed |
People
(Reporter: jonalmeida, Assigned: mkozinski)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid][group2])
Attachments
(1 file)
As part of bug 1992720, we had to cast the activity reference and find the NavHostFragment to finally navigate to the BrowserFragment. This is not typically the thing we would want to do in our controller (because it's hard to test and error-prone).
Can we instead delegate out navigation to somewhere else in the controller so that we have access to the NavController or a different way that we could perform the navigation?
|
Assignee | |
Updated•7 months ago
|
Blocks: review-prompt-followups
|
|
Assignee | |
Updated•3 months ago
|
Assignee: nobody → mkozinski
Status: NEW → ASSIGNED
Whiteboard: [fxdroid][group2]
|
||
Updated•3 months ago
|
|
|
Assignee | |
Comment 1•3 months ago
|
||
Pushed by mkozinski@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/f8efb7cfedd0
https://hg.mozilla.org/integration/autoland/rev/ccc867b4d4b7
Remove FragmentActivity cast from PlayStoreReviewPromptController r=android-reviewers,azinovyev,twhite
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
status-firefox151:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•