1997338 - CSS attr() cyclic reference detection

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[David Shin[:dshin]]

Cycle detection exists for custom properties - we need to extend it for attr(). This likely involves tracking their names as well as types.

Comment 1

[Swarup Ukil [:sukil]]

Bookmarking this comment by David. As well these.

Comment 2

[Swarup Ukil [:sukil]]

Attachment: Bug 1997338 - Clean up attr() cycle leftover from Bug 2009001. r=emilio,dshin

Specifically:

1. Fix a failing test in attr-cycle.html. Attr-values should only
   resolve references when prefaced by type() syntax. Else the
   attr-value is taken as is.

2. Cycle detection currently can't distinguish --data-foo (custom
   property) from data-foo (attribute), which can flag a false cycle
   in rare cases. Added a test to attr-cycle.html.

3. CSS-wide keywords aren't meaningful to attr() itself but can pass
   through directly or via the fallback. Added a test covering this.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d3f83bb38dc4
https://hg.mozilla.org/integration/autoland/rev/93f005409f29
Clean up attr() cycle leftover from Bug 2009001. r=emilio,firefox-style-system-reviewers

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/93f005409f29

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/60205 for changes under testing/web-platform/tests