1997351 - nocobase.prabhuls.me - Data viewer fails to load entries (table, entries, etc)

Status: VERIFIED FIXED

(Core :: SVG, defect, P2)

Description

[Raul Bucata]

Environment:
Operating system: Linux and Windows
Firefox version: Firefox 143.0

Steps to reproduce:

1. Navigate to: https://demo.nocobase.com/new and create a demo site
2. Perform account login with the received credentials via email for the demo site
3. From the settings menu (upper right corner), select "Dashboard"
4. Click on the "Configure" action for the main item
5. Add some entries (User) and observe

Expected Behavior:
Data/table is rendered

Actual Behavior:
Missing data/table

Notes:

• Reproduces regardless of the status of ETP
• Reproduces in firefox-nightly, and firefox-release
• Does not reproduce in chrome

Created from https://github.com/webcompat/web-bugs/issues/183994

Comment 1

[Raul Bucata]

Attachment: Chr vs ff

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Reduced test-case

This logs a degenerate matrix on firefox (all zeros), but an identity matrix in Chrome. Robert do you know who's right?

Maybe falling back to the identity matrix if we fail to invert or so is fine?

Comment 4

[Emilio Cobos Álvarez [:emilio]]

I guess bug 1992972 wasn't complete here.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1997351 - More explicitly deal with singular matrices in getCTM and getScreenCTM. r=jrmuizel,#firefox-svg-reviewers

This is much like bug 1992972, but a bit more general.

The issue in this case is that GetViewBoxTransform() is singular,
because of the zero viewport height:

https://searchfox.org/firefox-main/rev/cb52781342cc905eda923d009fc0b678f3a8c8c6/dom/svg/SVGViewportElement.cpp#162-164

Returning an identity matrix there seems a bit sketchy since it is used
in intermediate computations. Instead, deal with singular transforms at
the end of the process.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/569552b3a360
https://hg.mozilla.org/integration/autoland/rev/12f67b219f82
More explicitly deal with singular matrices in getCTM and getScreenCTM. r=jrmuizel

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/55902 for changes under testing/web-platform/tests

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/12f67b219f82

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox145 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9524748 [details]
Bug 1997351 - More explicitly deal with singular matrices in getCTM and getScreenCTM. r=jrmuizel,#firefox-svg-reviewers

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Relatively simple compat fix.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial-ish fix
• String changes made/needed: none
• Is Android affected?: Yes

Comment 12

[Robert Longson [:longsonr]]

Seems odd that neither Chrome nor Safari pass the wpt given that this is patch supposed to make us more compatible with them both.

https://wpt.fyi/results/svg/types/scripted/SVGGraphicsElement.getCTM-empty-viewBox.html?label=experimental&label=master&aligned

Comment 13

[Emilio Cobos Álvarez [:emilio]]

Hmm, let me look at that.

Comment 14

[Emilio Cobos Álvarez [:emilio]]

See bug 1999117

Comment 15

[Emilio Cobos Álvarez [:emilio]]

Local profile: https://profiler.firefox.com/public/0re1vgaq00h5v2abv4qxp96vj3ga6662qe9c6vg

Comment 16

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Reproduced the issue on Firefox 146.0a1 (2025-10-30) on macOS 26.1 where an "SVG Matrix.a setter" error is shown.

The graph is rendered as expected on Firefox 146.0a1 (2025-11-10). Tests were performed on macOS 26.1, Windows 11 and Ubuntu 24.04.

Comment 17

[Pascal Chevrel (relman team) -> :pascalc]

Comment on attachment 9524748 [details]
Bug 1997351 - More explicitly deal with singular matrices in getCTM and getScreenCTM. r=jrmuizel,#firefox-svg-reviewers

Approved for 145.0.1

Comment 18

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/ad23a2a7e872
https://hg.mozilla.org/releases/mozilla-release/rev/e1ccc9ad96fc

Comment 19

[Pascal Chevrel (relman team) -> :pascalc]

Emilio, do you want to provide a fix or maybe should we back it out from release? We have another dot release next week if needed.
Thanks

Comment 20

[Emilio Cobos Álvarez [:emilio]]

Fine to fix (sorry for the slow response, on JST timezone right now). This just hit a conflict with tests bug 1995807 had changed on central.

Comment 21

[Pascal Chevrel (relman team) -> :pascalc]

We built the dot release with the patch and didn't back it out, I am assuming that this is fine and that we can follow up uplifting the test changes in bug 1995807 in the next dot release?

Comment 22

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Verified that this is also fixed on Firefox 145.0.1. Tests were performed on macOS 26.1, Windows 11 and Ubuntu 24.04.

Comment 23

[Emilio Cobos Álvarez [:emilio]]

Yeah those changes are test only.

Comment 24

[Emilio Cobos Álvarez [:emilio]]

Err sorry I misread, we shouldn't uplift that one. https://bugzilla.mozilla.org/show_bug.cgi?id=2000679 has a patch attached with the test tweak.