Closed Bug 1997418 Opened 4 months ago Closed 4 months ago

Try removing `nsBlockFrame`'s `CalculateContainingBlockSizeForAbsolutes`

Categories

(Core :: CSS Parsing and Computation, enhancement)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
146 Branch
Tracking Flags:
Tracking Status
firefox146 --- fixed

People

(Reporter: dshin, Assigned: dshin)

References

Details

(Whiteboard: [anchorpositioning:m2])

Attachments

(1 file)

Bug 1997418: Simplify `nsBlockFrame`'s abspos cb computation. r=#layout
48 bytes, text/x-phabricator-request
Details | Review

This function, used purely to get the frame's absolute containing block size, seem to boil down to simply returning the padding rect size.

The only path where the rect is further modified is in line 1174, but I'm unsure if that path is used these days.

Most paths in the removed function returns the frame's padding
rect size. It doesn't seem that the single path that further
modifies the value is used.

Whiteboard: [anchorpositioning:triage]
Pushed by dshin@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/9af10c357816 https://hg.mozilla.org/integration/autoland/rev/e841ef9265e9 Simplify `nsBlockFrame`'s abspos cb computation. r=layout-reviewers,emilio,TYLin

https://hg.mozilla.org/mozilla-central/rev/e841ef9265e9

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
status-firefox146: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 146 Branch
Points: --- → 1
Whiteboard: [anchorpositioning:triage] → [anchorpositioning:m2]
QA Whiteboard: [qa-triage-done-c147/b146]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: