1997535 - Saved bookmarks sometimes display a broken meatball menu in the Firefox Suggest section

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Attachment: image.png

Found in

• Firefox Nightly 146.0a1;

Affected versions

• Firefox Nightly 146.0a1;
• Firefox 145.0b8;
• Firefox 144.0.2;

Tested platforms

• Windows 10;
• Ubuntu 22;
• macOS 15;

Affected platforms

• Windows 10;
• Ubuntu 22;
• macOS 15;

Unaffected platforms

• N/A;

Steps to reproduce

1. Launch Firefox.
2. Navigate to a website, eg. wikipedia and bookmark it 2 different wikipedia pages.
3. Close the newly-bookmarked pages and open a new tab.
4. Focus the address bar and write the first letters of the bookmarked sites, eg. ‘wiki’.
5. Click on the bookmark’s meatball menu.

Expected result

• No meatball menu should be displayed for bookmarks.

Actual result

• Broken meatball menu.

Regression range

• last good: 2025-07-10;
• first bad: 2025-07-11;
• pushlog: https://hg-edge.mozilla.org/integration/autoland/pushloghtml?fromchange=679e46b0ff8f3e9f1bf8e6cf8601b8ae8b0ca7fc&tochange=a5e45dd880e9e63bfe01d1f92ff3a8a5fe77c7f4
• potentially regressed by: bug 1975336

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1975336

:daisuke, since you are the author of the regressor, bug 1975336, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Dale Harvey (:daleharvey)]

Potentially reusing the row and not clearing CSS correctly, needs investigation

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1975336

Comment 4

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1997535: Fix wrong needsNewContent calculation

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ca2ec1f19a8e
https://hg.mozilla.org/integration/autoland/rev/a363eb5db7d3
Fix wrong needsNewContent calculation r=adw

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a363eb5db7d3

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:daisuke, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox146 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Occasionally, the wrong menu items appear in the suggestions.
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: The patch affects the urlbar suggestions, but it does not affect its content.
• String changes made/needed: None
• Is Android affected?: no

Comment 9

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1997535: Fix wrong needsNewContent calculation

Original Revision: https://phabricator.services.mozilla.com/D271767

Comment 10

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/bc48fd07ff0c
https://hg.mozilla.org/releases/mozilla-beta/rev/d8c927886b33