1997637 - [composable toolbar] "Fill link from clipboard" dropdown shows up (and is unusable) in custom tabs, if it's present in main Firefox session

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, defect)

Description

[Daniel Holbert [:dholbert]]

Steps to reproduce

1. Have Firefox Nightly set to be your default browser.
2. Copy a URL to your clipboard.
3. Open a new tab in Firefox and tap the URL bar, so that "Fill link from clipboard" UI shows up (attached to the URL bar)
4. Switch to another app (e.g. Gmail) and tap a link to open a custom tab.

Expected behavior

Regular-looking custom tab.

Actual behavior

The Custom Tab has "Fill link from clipboard" present, attached to its (non-editable) toolbar. (Somewhat-unsurprisingly, it doesn't do anything if you tap it.)

Device information

• Firefox version: 146.0a1 Nightly
• Android device model: Pixel 6a
• Android OS version: 16

Any additional information?

This bug reproduce if the Composable Toolbar is enabled.
So it affects Nightly 146 and Firefox 145 beta (tested & confirmed); and I tried turning off the Composable Toolbar option in beta and confirmed that the bug stopped reproducing.

It does not affect Firefox 144 release by default (because Composable Toolbar is off-by-default there); but if I use secret-settings to enable Composable Toolbar (and then quit-and-restart Firefox and Gmail for good measure), then it reproduces there too.

Note, this is superficially similar to bug 1993429 (see bug 1993429 comment 2 which mentions it being expected that we potentially show the "Fill link from clipboard" multiple times), but in this case here, we're showing it in a place where it's not useful and not functional.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screencast showing the bug ("fill link from keyboard" shows up but is unusable at t=10s)

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screenshot of bug

Comment 3

[Daniel Holbert [:dholbert]]

[ni=petru for triage since I think he's working on this feature]

Also, even though I was able to repro on beta (145.0b8), it looks like we can consider this disabled for v145 via bug 1997076 which landed after the commit that b8 was built from.

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Thanks for the ping!
Interesting scenario!

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1997637 - Ensure the AwesomeBar is not shown in custom tabs r=#android-reviewers

Guard showing the AwesomeBar in custom tabs similarly to how we check
and avoid showing the TabStrip in custom tabs.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/864273873be4
https://hg.mozilla.org/integration/autoland/rev/402ed2e1289e
Ensure the AwesomeBar is not shown in custom tabs r=android-reviewers,skhan

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/402ed2e1289e