Closed Bug 1997653 Opened 1 year ago Closed 1 month ago

Use named exports for UI Widgets component classes

Categories

(Toolkit :: UI Widgets, task, P3)

task

Tracking

()

RESOLVED FIXED
159 Branch
Tracking Status
firefox159 --- fixed

People

(Reporter: mstriemer, Assigned: mstriemer)

References

(Blocks 1 open bug)

Details

(Whiteboard: [recomp])

Attachments

(1 external file)

We generally use default exports for our components, but we have a number of cases where we use named exports. Some of these still have a default export (like MozSelect as default, MozOption as named) but some others have multiple named exports with none being default (MozBreadcrumbGroup, MozBreadcrumb).

This inconsistency can be a bit annoying when importing a component (or its types) since it isn't immediately obvious which one to use.

Let's convert all of the default exports to be named exports so there's no more guessing.

These are the default exports to update, note that mach_commands.py is in there too, it should indeed be updated so that new files created with ./mach addwidget follow our updated conventions

Blocks: acorn-web
Assignee: nobody → mstriemer
Status: NEW → ASSIGNED
Pushed by mstriemer@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/46575f7796fa https://hg.mozilla.org/integration/autoland/rev/f66bcdcdf9b5 Use named exports for UI Widgets component classes. r=settings-reviewers,reusable-components-reviewers,urlbar-reviewers,hjones,jteow,ngrato
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 159 Branch
QA Whiteboard: [qa-triage-done-c160/b159]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: