1997773 - Consider hiding the frame loader earlier in nsFrameLoader::Destroy.

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1997773 - Hide frameloader before nulling out embedder element from nsFrameLoader::Destroy(). r=smaug!

Yeah, I know... non-trivial one-liner.

I found some weirdness while looking at bug 1994942. Issue is that I
tried to remove the nsView dependency by looking at the embedder
element (right now layout goes from child to parent frame via the view
tree).

This mostly works, except when the presshell is destroyed after the
frameloader. This patch prevents that from happening and makes the
timing a bit more predictable between subframes / reframes and process
switches, even though I ultimately found a workaround for that bug.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/866e3560b261
https://hg.mozilla.org/integration/autoland/rev/69fb6930ebd4
Hide frameloader before nulling out embedder element from nsFrameLoader::Destroy(). r=smaug

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/03d91a5457c0
https://hg.mozilla.org/integration/autoland/rev/7f2910f63872
Allow a non-fatal assert on test_reporturl.html

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/69fb6930ebd4
https://hg.mozilla.org/mozilla-central/rev/7f2910f63872