1997810 - Bookmarks menu cut off at the bottom

Status: RESOLVED DUPLICATE of bug 1998949

(Core :: Widget: Gtk, defect, P3)

Description

[Viktor Jägersküpper]

OS: Arch Linux, observed with KDE Plasma and Gnome

Steps to reproduce:

• Add many bookmarks to the bookmarks menu so that the bookmarks menu popup becomes scrollable
• Either open the bookmarks menu via the menu bar or add the bookmarks button to the toolbar and click on it
  -> If you scroll down, you can't reach the bookmarks at the bottom of the list because the popup is cut off.

Additionally I get the following warning in the terminal:

[Parent 7523, Main Thread] WARNING: gdk_window_get_position: assertion 'GDK_IS_WINDOW (window)' failed: 'glib warning', file /builds/worker/checkouts/gecko/toolkit/xre/nsSigHandlers.cpp:201
(firefox-nightly:7523): Gdk-CRITICAL **: 20:56:35.762: gdk_window_get_position: assertion 'GDK_IS_WINDOW (window)' failed

This is what I observe with KDE Plasma. It's worse with Gnome because in addition the popup only flickers on the first (and maybe second?) attempt to open the bookmarks menu.

I ran mozregression and got:
Last good revision: 2c449ac57a9062ead7243b27bb5dceb94b804c5c
First bad revision: d51bf7d6db72d1f039cd874eee72bfdd352f59af
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2c449ac57a9062ead7243b27bb5dceb94b804c5c&tochange=d51bf7d6db72d1f039cd874eee72bfdd352f59af

Most likely bug 1992198 is the regressor.

Comment 1

[Viktor Jägersküpper]

I forgot to note that I only tested on Wayland.

Comment 2

[BugBot [:suhaib / :marco]]

:stransky, since you are the author of the regressor, bug 1992198, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Is that really a regression? Or is that a spin off Bug 1987508 Bug 1987162 ?

Comment 4

[Viktor Jägersküpper]

There are two different issues which might interfere with each other. This is the current state:

1. The top level and nested popups are cut off. (this bug)
2. A nested popup is placed correctly when it is opened for the first time, but after closing it and waiting for more than 15 seconds it's placed incorrectly. (bug 1987508 if you disregard that the popup is also cut off, and maybe bug 1987162?)

The 2. issue seems to be a regression by bug 1975823, but it's also possible that the change from bug 1975823 only uncovered a bug that was there before. Both issues seem to be related to some sort of caching if I understand correctly.

Side note: I just noticed that the bookmarks popup opened via the menu bar also flickers on KDE Plasma, but only if the browser window is not maximized.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Can you please attach screencast how it looks like?
https://fedoraproject.org/wiki/How_to_debug_Firefox_problems#Create_screenshot/screencast_for_a_bug_report
That will help me greatly to understand what's going on.
Thanks.

Comment 6

[Viktor Jägersküpper]

Attachment: screencast-mozilla-bug-1997810.mp4

I added a certain number of bookmarks so that when the windows is maximized, the popup opened via the toolbar button is scrollable, whereas the popups opened via the menu bar are not scrollable so that you can see the difference.

(Inadvertently I also recorded an incorrectly placed nested popup opened via the toolbar button.)

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Thanks for the video. Is the flickering part of the bug or is that just a recording artifact?
Thanks.

Comment 8

[Viktor Jägersküpper]

The flickering is not a recording artifact, so I guess it is part of the bug. I recorded the video on my laptop with an Intel Broadwell iGPU. On this laptop running KDE Plasma, the flickering is visible as shown in the video when the browser window is not maximized and it is visible for a fraction of a second when the browser window is maximized.

Can you reproduce the bug on your hardware?

Comment 9

[Viktor Jägersküpper]

I just tested the "last good" and "first bad" autoland builds again on my laptop, the flickering wasn't there/visible with the "last good" build.

Side note regarding the "caching": If I scroll down in the bookmarks popup (opened via the menu bar or via the button in the toolbar), click on a bookmark (so that the popup is closed) and then open the bookmarks popup again, the scroll position is remembered. Interestingly there is bug 1823063, which is about that the scroll position is not remembered when a popup is opened via the bookmarks toolbar. Maybe (a part of) the fix for this bug is to also "forget"/reset the scroll position for the popups opened via the menu bar and the toolbar button?

Comment 10

[Martin Stránský [:stransky] (ni? me)]

Okay, may be the same as Bug 1998949 then.

Comment 11

[Viktor Jägersküpper]

This is resolved by the fix for bug 1998949.

Martin, please mark this as duplicate because it seems I can't do that.

Comment 12

[Martin Stránský [:stransky] (ni? me)]

Okay, Thanks!