1997959 - Please add policies.is_enterprise to baseline ping

Status: RESOLVED FIXED

(Firefox :: Enterprise Policies, defect, P3)

Description

[Katie Windau]

Would someone be able to add policies.is_enterprise to the baseline ping? It's currently on metrics and events only right now, and if it were on the baseline ping, it would help us with being able to add "is enterprise" to the baseline active users aggregates table, which is a request from Romain Testard.

https://dictionary.telemetry.mozilla.org/apps/firefox_desktop/metrics/policies_is_enterprise

Comment 1

[Chris H-C :chutten]

This is slightly complicated by policies.is_enterprise having ping lifetime (to match the Scalar it was migrated from). I'm guessing it would be intended to have lifetime: application were it implemented today with Glean.

Passing to Enterprise Policies who own the collection to decide how to proceed.

Comment 2

[Mike Kaply [:mkaply]]

It is lifetime: application?

https://searchfox.org/firefox-main/source/toolkit/components/enterprisepolicies/metrics.yaml#52

Comment 3

[Chris H-C :chutten]

Oh, it is! Goodness, how'd I miss that. I even wrote it. I blame.... DST ending. Yeah, that must've been it.

Comment 4

[Mike Kaply [:mkaply]]

Where are the values for send_in_pings documented?

Comment 5

[Chris H-C :chutten]

A few places: https://mozilla.github.io/glean/book/user/pings/custom.html#sending-metrics-in-a-custom-ping and https://mozilla.github.io/glean/book/reference/yaml/metrics.html#send_in_pings are the two that I'd expect folks to find first

Comment 6

[Mike Kaply [:mkaply]]

So I guess it's just a matter of adding baseline to our send_in_pings?

Will that affect any other reporting?

Comment 7

[Chris H-C :chutten]

It will not. But it will make each "baseline" ping a little bit larger. Those pings can be submitted quite frequently, so we have a vested interest in keeping it as small as possible, so you may need to no_lint a rule to convince glean_parser that you've weighed the weight and found it worth it for the benefit.

Comment 8

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:mkaply, could you have a look please?

For more information, please visit BugBot documentation.

Comment 9

[Mike Kaply [:mkaply]]

But it will make each "baseline" ping a little bit larger. Those pings can be submitted quite frequently, so we have a vested interest in keeping it as small as possible, so you may need to no_lint a rule to convince glean_parser that you've weighed the weight and found it worth it for the benefit.

Am I allowed to make that determination? Do I need outside input?

Comment 10

[Chris H-C :chutten]

That's a rather unfortunately loaded question of the form "Is the cost of this worth the benefit?" paired with "Who owns this data/is responsible for making that decision?" which we don't have answers for.

So for this case in particular... eh, might as well go for it. If it ends up not being worth the cost, we can turn it off later with Server Knobs.

Comment 11

[Mike Kaply [:mkaply]]

Attachment: Bug 1997959 - Add is_enterprise to baseline ping. r?chutten

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cc5f8e76ee67
https://hg.mozilla.org/integration/autoland/rev/43f53c79f89d
Add is_enterprise to baseline ping. r=chutten

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/43f53c79f89d