1997997 - Assertion failure: !SupportsOnly8BitImage() || std::all_of(aImages.begin(), aImages.end(), Is8BitImage) (Images should be 8-bit), at /builds/worker/checkouts/gecko/dom/media/VideoFrameContainer.cpp:133

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Tyson Smith [:tsmith]]

Found with m-c 20251102-d0c1a4b1cb72 (--enable-debug)

This was found by visiting a live website with a debug build.

STR:

• Launch browser and visit site

This issue was triggered by visiting http://launchdarkly.com/.

Assertion failure: !SupportsOnly8BitImage() || std::all_of(aImages.begin(), aImages.end(), Is8BitImage) (Images should be 8-bit), at /builds/worker/checkouts/gecko/dom/media/VideoFrameContainer.cpp:133

39|0|libxul.so|mozilla::VideoFrameContainer::SetCurrentFramesLocked(mozilla::gfx::IntSizeTyped<mozilla::gfx::UnknownUnits> const&, nsTArray<mozilla::layers::ImageContainer::NonOwningImage> const&)|hg:hg.mozilla.org/mozilla-central:dom/media/VideoFrameContainer.cpp:d0c1a4b1cb725aaff109054e060729eb71099baf|131|0x4a0
39|1|libxul.so|mozilla::VideoFrameContainer::SetCurrentFrame(mozilla::gfx::IntSizeTyped<mozilla::gfx::UnknownUnits> const&, mozilla::layers::Image*, mozilla::TimeStamp const&, mozilla::media::TimeUnit const&, mozilla::media::TimeUnit const&)|hg:hg.mozilla.org/mozilla-central:dom/media/VideoFrameContainer.cpp:d0c1a4b1cb725aaff109054e060729eb71099baf|97|0x2af
39|2|libxul.so|mozilla::VideoSink::Redraw(mozilla::VideoInfo const&)|hg:hg.mozilla.org/mozilla-central:dom/media/mediasink/VideoSink.cpp:d0c1a4b1cb725aaff109054e060729eb71099baf|356|0x16b
39|3|libxul.so|mozilla::MediaDecoderStateMachine::FinishDecodeFirstFrame()|hg:hg.mozilla.org/mozilla-central:dom/media/MediaDecoderStateMachine.cpp:d0c1a4b1cb725aaff109054e060729eb71099baf|4240|0xc2
39|4|libxul.so|mozilla::MediaDecoderStateMachine::DecodingFirstFrameState::MaybeFinishDecodeFirstFrame()|hg:hg.mozilla.org/mozilla-central:dom/media/MediaDecoderStateMachine.cpp:d0c1a4b1cb725aaff109054e060729eb71099baf|3032|0x9a
39|5|libxul.so|mozilla::MozPromise<RefPtr<mozilla::VideoData>, mozilla::MediaResult, true>::ThenValue<mozilla::MediaDecoderStateMachine::RequestVideoData(mozilla::media::TimeUnit const&, bool)::$_0, mozilla::MediaDecoderStateMachine::RequestVideoData(mozilla::media::TimeUnit const&, bool)::$_1>::DoResolveOrRejectInternal(mozilla::MozPromise<RefPtr<mozilla::VideoData>, mozilla::MediaResult, true>::ResolveOrRejectValue&)|hg:hg.mozilla.org/mozilla-central:xpcom/threads/MozPromise.h:d0c1a4b1cb725aaff109054e060729eb71099baf|874|0x37f
39|6|libxul.so|mozilla::MozPromise<mozilla::MetadataHolder, mozilla::MediaResult, true>::ThenValueBase::ResolveOrRejectRunnable::Run()|hg:hg.mozilla.org/mozilla-central:xpcom/threads/MozPromise.h:d0c1a4b1cb725aaff109054e060729eb71099baf|505|0x4d
39|7|libxul.so|mozilla::AutoTaskDispatcher::TaskGroupRunnable::Run()|hg:hg.mozilla.org/mozilla-central:xpcom/threads/TaskDispatcher.h:d0c1a4b1cb725aaff109054e060729eb71099baf|234|0x1c7
39|8|libxul.so|mozilla::TaskQueue::Runner::Run()|hg:hg.mozilla.org/mozilla-central:xpcom/threads/TaskQueue.cpp:d0c1a4b1cb725aaff109054e060729eb71099baf|263|0x2fd
39|9|libxul.so|nsThreadPool::Run()|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThreadPool.cpp:d0c1a4b1cb725aaff109054e060729eb71099baf|449|0x80b
39|10|libxul.so|nsThread::ProcessNextEvent(bool, bool*)|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThread.cpp:d0c1a4b1cb725aaff109054e060729eb71099baf|1160|0x781
39|11|libxul.so|NS_ProcessNextEvent(nsIThread*, bool)|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThreadUtils.cpp:d0c1a4b1cb725aaff109054e060729eb71099baf|461|0x4f
39|12|libxul.so|mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*)|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessagePump.cpp:d0c1a4b1cb725aaff109054e060729eb71099baf|299|0xc6
39|13|libxul.so|MessageLoop::Run()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:d0c1a4b1cb725aaff109054e060729eb71099baf|343|0x61
39|14|libxul.so|nsThread::ThreadFunc(void*)|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThread.cpp:d0c1a4b1cb725aaff109054e060729eb71099baf|375|0x15b
39|15|libnss3.so|_pt_root|hg:hg.mozilla.org/mozilla-central:nsprpub/pr/src/pthreads/ptthread.c:d0c1a4b1cb725aaff109054e060729eb71099baf|191|0x192
39|16|libmozglue.so|set_alt_signal_stack_and_start(PthreadCreateParams*)|hg:hg.mozilla.org/mozilla-central:mozglue/interposers/pthread_create_interposer.cpp:d0c1a4b1cb725aaff109054e060729eb71099baf|81|0xd5

Comment 1

[John Lin [:jhlin][:jolin]]

Hi Tyson, thanks for the report! Could you please upload the about:support data for us to check?

Comment 2

[Tyson Smith [:tsmith]]

Attachment: about-support.txt

Yes, of course.

Comment 3

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1997997 - add VP9 8-bit output conversion to FFmpegVideoDecoder.

Some Android GPUs doesn't support 10/12/16-bit image and need conversion
from the decoder. It's not added to VPXDecoder because only I420/I44 are
supported there.

Comment 4

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1997997 - add test for 10/12-bit VP9 video.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/392dd465ebf1
https://hg.mozilla.org/integration/autoland/rev/e67d25c1d07b
add VP9 8-bit output conversion to FFmpegVideoDecoder. r=media-playback-reviewers,alwu
https://github.com/mozilla-firefox/firefox/commit/1a24cc95a257
https://hg.mozilla.org/integration/autoland/rev/627e19511a39
add test for 10/12-bit VP9 video. r=media-playback-reviewers,alwu

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e35b0c17ca11
https://hg.mozilla.org/integration/autoland/rev/069c470dfb00
Revert "Bug 1997997 - add test for 10/12-bit VP9 video. r=media-playback-reviewers,alwu" for causing mda failure on test_non_8bit_video.html

Comment 7

[Narcis Beleuzu [:NarcisB]]

Backed out for causing mda failure on test_non_8bit_video.html

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/069c470dfb00b728ea799a59c9083ae347549b74
Log link: https://treeherder.mozilla.org/logviewer?job_id=535098926&repo=autoland&task=csJkOTV0R_2f-XGgg4LJWg.0&lineNumber=4494

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b34e51f3b751
https://hg.mozilla.org/integration/autoland/rev/6e434421e25a
add VP9 8-bit output conversion to FFmpegVideoDecoder. r=media-playback-reviewers,alwu
https://github.com/mozilla-firefox/firefox/commit/8e669ed1c8ea
https://hg.mozilla.org/integration/autoland/rev/98683c3cb926
add test for 10/12-bit VP9 video. r=media-playback-reviewers,alwu

Comment 9

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/6e434421e25a
https://hg.mozilla.org/mozilla-central/rev/98683c3cb926

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jhlin, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox146 to wontfix.

For more information, please visit BugBot documentation.