1998098 - [Windows] Investigate if we need to unblock WMF video decoding to P010 on NVIDIA

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task)

Description

[Ashley Hale [:ahale]]

For reasons that may no longer be relevant, we blocked use of MFVideoFormat_P010 on NVIDIA, we may not need to block this anymore, and it may be relevant to HDR video.

It may or may not be a good idea to block this format anymore, investigation needed.

Comment 1

[Ashley Hale [:ahale]]

https://searchfox.org/firefox-main/rev/f6385e6644d5d4343d33b692810275c434122199/widget/windows/GfxInfo.cpp#1619 is the relevant blocklist code.

Comment 2

[Ashley Hale [:ahale]]

Need info - do we know why this is blocked on Nvidia and do we think it still needs to be? HDR decoding obviously uses this format and we're trying to ship HDR video on all Nvidia cards that are capable (which goes back to GTX 900 series).

Comment 3

[Alastor Wu [:alwu]]

Per this revision, the failure reason wasn’t explained. However, since the change was made nearly eight years ago, we could try re-enabling it to see if anything breaks.

Comment 4

[Ashley Hale [:ahale]]

In that case I say we unblock it, Windows itself has changed a lot in that time, and the drivers got plenty of updates in that time range, given that HDR requires this I would expect they fixed any issues already.

Comment 5

[Ashley Hale [:ahale]]

Attachment: Bug 1998098 - Unblock P010 video decoding on NVIDIA on Windows r?#gfx-reviewers

Comment 6

[Brad Werth [:bradwerth]]

Hopefully this will remind us to add a test for this case, when we have tests.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0e322d9bc040
https://hg.mozilla.org/integration/autoland/rev/14c2487cc466
Unblock P010 video decoding on NVIDIA on Windows r=gfx-reviewers,win-reviewers,bradwerth,gstoll

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/14c2487cc466

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/14c2487cc466