1998121 - Navigation event has wrong navigationType for clicks to the current URL

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Holger Benl [:hbenl]]

When clicking on a link that points to the URL of the current page, the navigation event has navigationType set to push even though the click reloads the page replacing the current navigation history entry instead of adding a new one. In Chrome, the navigationType is replace.

STR:

• open https://hbenl.github.io/test/navigationtype/no-polyfill.html in current Nightly
• open the console and enable "Persist Logs"
• click on the link

Expected: the console shows "replace"
Actual: the console shows "push"

Furthermore I've noticed that after clicking the link, navigation.canGoBack is true even if the browser's back button is disabled and the 2 entries in navigation.activation have different keys. In Chrome, navigation.canGoBack is false in this case and the 2 entries in navigation.activation have the same key (see https://developer.mozilla.org/en-US/docs/Web/API/NavigateEvent/navigationType#:~:text=This%20new%20entry%20will%20reuse%20the%20same%20key%2C%20but%20be%20assigned%20a%20different%20id).

Comment 1

[Andreas Farre [:farre]]

This is again a missing push -> replace conversion, but this time for #following-hyperlinks-2. This is a scary one-liner, so I'm running a fairly big try for this.

Comment 2

[Andreas Farre [:farre]]

Attachment: Bug 1998121 - Make following a hyperlink do push/replace conversion.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/dc09d8d832f1
https://hg.mozilla.org/integration/autoland/rev/ef3da96baddc
Make following a hyperlink do push/replace conversion. r=smaug

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ef3da96baddc

Comment 5

[Monica Chiorean]

I was able to reproduce the issue on Win11x64 using FF build 146.0a1(20251104214230) I see push in the browser console like on description.
Issue also reproduces on beta 146.0b2 and also on 147.0a1.
Andreas, is there something that I am missing?

Comment 6

[Andreas Farre [:farre]]

Attachment: Bug 1998121 - Manually change LOAD_LINK to LOAD_NORMAL_REPLACE. r=#dom-core!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9243421d508e
https://hg.mozilla.org/integration/autoland/rev/744e719a0999
Manually change LOAD_LINK to LOAD_NORMAL_REPLACE. r=dom-core,smaug

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/56085 for changes under testing/web-platform/tests

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/744e719a0999

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot