Closed Bug 199813 Opened 17 years ago Closed 17 years ago

Make all users of ThrowUserError pass $vars in explictly

Categories

(Bugzilla :: Bugzilla-General, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: bbaetz, Assigned: bbaetz)

References

Details

Attachments

(1 file)

As part of removing the global $vars hash, the various Throw*Error functions
need to get passed their $vars explcitly, rather than just picking up the global
stuff.

(Only header_done is excemt from this, for the moment - its a bigger issue to fix)

Patch coming after I finish testing it.

Also fixes bug 181553 (whcih I noted separately)
Also, I've fixed an incorrect Throw from userprefs.cgi (where we thrw the var
name, instead of the template name, and replaced a variables.sortkey with jus
sortkey (variables in only in ThrowCodeError, and not for long...) Also fixed an
issue in attachment.cgi where we needed to give the bug # in teh error message,
but used the attachment number'd error template.
Summary: Make all users of ThrowUserError pass $vars in explicilty → Make all users of ThrowUserError pass $vars in explictly
Attached patch patchSplinter Review
OK, this also removes the example bit from the default templte, and rempves the
backwards compat code for using the error tag as the actual message - that all
got removed a while back.
Attachment #118879 - Flags: review?(gerv)
Comment on attachment 118879 [details] [diff] [review]
patch

r=gerv. Looks fine to me.

Gerv
Attachment #118879 - Flags: review?(gerv) → review+
Flags: approval?
Flags: approval? → approval+
Checked in.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → Bugzilla 2.18
Blocks: bz-globals
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.