1998292 - Drop `product` dimension and `fenix` product flavor in Fenix Gradle configuration

Status: RESOLVED FIXED

(Firefox for Android :: Tooling, enhancement)

Description

[Nick Alexander :nalexander [he/him]]

There's a historical oddity in the Fenix Gradle configuration: there's a product dimension with a single fenix product flavor. We should drop it. See here.

There was some discussion on Slack and there's no reason to keep it. There are reasons to not remove it: it churns a great deal of things for little benefit (beyond every engineer being surprised that the Gradle targets include Fenix in unexpected places). As we unify Gradle configurations (Bug 1983929) and therefore move a lot of files around in our task definitions, we might do this at the same time.

Comment 1

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 1998292 - Remove 'product' dimension and `fenix` product flavor r?nalexander

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e45538fc3799
https://hg.mozilla.org/integration/autoland/rev/0255fefc5567
Remove 'product' dimension and `fenix` product flavor r=geckoview-reviewers,android-reviewers,tcampbell,releng-reviewers,jcristau

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox for Android::Tooling' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/0255fefc5567

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Do we have plans to do the same for Focus?

Comment 6

[Alex Hochheiden [:ahochheiden] [he/him]]

I think focus and klar are legitimate product flavors. As far as I know, focus is an existing brand in Germany, so we have the product flavor klar so we don't infringe on their brand/trademark. Which is the correct usage of a product flavor per my understanding, but Nick can confirm/deny that.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Oh right, for some reason I completely brainfarted on that! 🤦

Comment 8

[Nick Alexander :nalexander [he/him]]

(In reply to Alex Hochheiden [:ahochheiden] [he/him] from comment #6)

I think focus and klar are legitimate product flavors. As far as I know, focus is an existing brand in Germany, so we have the product flavor klar so we don't infringe on their brand/trademark. Which is the correct usage of a product flavor per my understanding, but Nick can confirm/deny that.

Just so.