19983 - Anchor Link not working inside Label element

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[Chris Petersen]

Version: Apprunner
Build: 1999112308
Platforms: All

Expected Results: The link (created by a A element) should function when clicked
on.

What I got: The link is not functional.

Steps to reproduce:

1) Open Apprunner
2) Select the following test case: http://slip/projects/marvin/simple/
label_a.html
3) Click on the link. Nothing happens.

Comment 1

[Chris Petersen]

Attachment: A small test case with Label and nested A element

Comment 2

[karnaze (gone)]

Reassigning to Kevin.

Comment 3

[gerardok]

QA Contact update.

Comment 4

[Sean Richardson]

Attachment: <LABEL> examples per spec, but containing <A>

Comment 5

[Sean Richardson]

Lifted testcases from spec, wrapped <A> elements around the label text and
attached to this bug...

It appears that the <LABEL> element is meant to be used in one of two quite
different ways, and the first testcase does not apply directly to
either of them.

The spec at http://www.w3.org/TR/REC-html40/interact/forms.html#h-17.9.1 says
(at the end of the section):
   >When a LABEL element receives focus, it passes the focus on to its
   >associated control. See the section below on access keys for
   >examples.
This obviously conflicts with the what <A> elements do upon receiving focus.

The spec also says (in the same section) that either <LABEL> is used with a
"for='someid'" attribute associated with an "id='someid'" attribute of a form
control, OR, is used with the label text and the form control as its only
contents.

Tested, this work correctly by the spec, but incorrectly by expectations that
the Anchor elements will work normally. In both forms, clicking on the links
made inside the <LABEL> elements does not load the linked page, but
flashes the associated form control and then shifts focus to the associated
form control (can be verified by typing). The flash happens only the first
time, but the change of focus happens on any click to such an anchor.

The same result happens with a third form on the testcase that has no
Anchors inside the <LABEL> element - this is according to spec.

In a fourth form, label text both inside and outside an <A> element
passes focus to the associated form control equivalently.

* Tested with:
1999-12-09-08-M12 nightly binary on Windows NT 4.0sp3.

* Additional Information:
Without the fourth form, this bug report looks like it is INVALID,
but it may be reasonable to have an <A> inside a <LABEL> work normally
so long as there is some other content to act as the label proper.

On the other hand, that is complex, and in any case where
"<LABEL><A>anchor content</A> label content</LABEL>" may be desired,
surely "<A>anchor content</A> <LABEL>label content</LABEL>" could be used.

Comment 6

[Kevin McCluskey (gone)]

Looking at the nsLabelFrame implementation is it will only pass events down
to a nsIFormControlFrame. nsLabelFrame::GetFrameForPoint will return the label
frame unless it has a child frame with is a nsIFormControlFrame. We need to make
the label frame more general.

Comment 7

[Kevin McCluskey (gone)]

Moving to M15

Comment 8

[Kevin McCluskey (gone)]

Reassigning to Rod

Comment 9

[rods (gone)]

I have the fix

Comment 10

[rods (gone)]

Fixed

Comment 11

[ckritzer (gone)]

Re-opening bug and setting severity to critical.  Tested on:
- MacOS86 2000-01-26-03 Commercial Build
- Linux6 2000-01-25-20 Commercial Build
- Win98 2000-01-25-20 Commercial Build

Comment 12

[ckritzer (gone)]

Clearing FIXED resolution due to re-open.

Comment 13

[ckritzer (gone)]

Whoops...I think I re-opened prematurely...sorry rods, I just saw the
time/datestamp on this bug...
Is your fix getting picked up in the 2000-01-27-xx M13 or M14 builds?  If you
could let me know I'll check out the appropriate build and then close out this
bug for you.  Thanks and sorry again for blasting through this bug...

Comment 14

[rods (gone)]

It should be fixed in today's M14 build. I checked it in this morning.

Comment 15

[ckritzer (gone)]

Marking VERIFIED FIXED on:
- Linux6 2000-02-01-10 Commercial build
- Win98 2000-02-01-08 Commercial build
- MacOS86 2000-02-01-09 Commercial build