1998357 - incorrect inactive CSS on pseudo element when CSS rules has selectors with multiple pseudo element

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Navigate to data:text/html,<meta charset=utf8><style>h1::before, h1::after { position: absolute; content: "-"; top: 0; }</style><h1>Hello
2. Open the inspector
3. Expand the <h1> node
4. Select the ::before node
5. Select the ::after node

Expected results

The top: 0 declaration is never inactive

Actual results

The top: 0 declaration is declared inactive when selecting the ::before node

Comment 1

[Alexandre Poirot [:ochameau]]

Simplifying the logic of pseudo element in the backend fix that "for free".

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1998357 - [devtools] Simplify backend logic about pseudo elements. r=#devtools

When selecting a pseudo elements, the rules for it aren't
considered as pseudo elements rules.
We currently have a workaround to nullify pseudoElement on the
appliedstyle object.

But we could simplify the logic here to stop involving a binding element
and pseudo element string when fetching rules for the selected pseudo
element.

Pseudo element rules should only be about rules for pseudo elements
which are children of the currently selected element.
i.e. the logic at the end of #getAllElementRules, after skipPseudo.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d02a28df0263
https://hg.mozilla.org/integration/autoland/rev/8e822a0c054c
[devtools] Simplify backend logic about pseudo elements. r=devtools-reviewers,nchevobbe

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/8e822a0c054c