1998360 - "Remove from sidebar" context menu item appears when right-clicking empty areas of sidebar

Status: RESOLVED FIXED

(Firefox :: Sidebar, defect, P1)

Description

[Kestrel]

Attachment: Sidebar context menu showing "Remove from sidebar"

STR:

1. Open sidebar with vertical tabs disabled on latest Nightly 146.0a1.
2. Right-click in sidebar blank area beneath tools.
3. Click "Remove from Sidebar" menu item.

Expected:
"Remove from Sidebar" menu item only appears when right-clicking on something that can be removed.

Actual:
"Remove from Sidebar" menu item appears and does nothing when clicked. Does not appear when right-clicking on tools.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a2bb12561eadb4d3a49d5e3c6cfedce3ef624dca&tochange=93456979c3920e890cabd40db795ac457013bc9d

Regressed by Bug 1944719.

Comment 1

[BugBot [:suhaib / :marco]]

:sclements, since you are the author of the regressor, bug 1944719, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1944719

Comment 3

[Sarah Clements [:sclements]]

Attachment: Bug 1998360 - Ensure that Remove from Sidebar context menu only applies to extensions r=#sidebar-reviewers-rotation

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/49f28e9329ba
https://hg.mozilla.org/integration/autoland/rev/741f5fa35034
Ensure that Remove from Sidebar context menu only applies to extensions r=nsharpley

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/741f5fa35034

Comment 6

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:sclements, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox146 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Can result in a confusing experience as the "Remove from sidebar" menu option is currently visible in the right-click menu regardless of whether the mouse/focus is on an extension button (which is the only element that should have the "Remove from sidebar" option).
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: See the first comment in the bug - first install an extension (sidebery or TST, for example) and then right-click anywhere in the sidebar (with horizontal tabs enabled).
• Risk associated with taking this patch: low
• Explanation of risk level: The patch ensures hidden state of this particular menu item is reset and adds an assert to existing test coverage.
• String changes made/needed: No
• Is Android affected?: no

Comment 8

[Sarah Clements [:sclements]]

Attachment: Bug 1998360 - Ensure that Remove from Sidebar context menu only applies to extensions

Original Revision: https://phabricator.services.mozilla.com/D272164

Comment 9

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/55ba7e386f79
https://hg.mozilla.org/releases/mozilla-beta/rev/a54fc3b66ca3

Comment 10

[Ciprian Georgiu, Desktop QA]

I have reproduced this issue using an affected Nightly build (2025-11-05) on Win 11.

The issue is verified as fixed on latest Beta 146.0b6 and Nightly 147.0a1 under macOS 26, Ubuntu 24, Win 11.