Closed
Bug 1998430
Opened 9 months ago
Closed 9 months ago
Ensure setting-group element responds to toggle events
Categories
(Firefox :: Settings UI, task)
Firefox
Settings UI
Tracking
()
RESOLVED
FIXED
146 Branch
| Tracking | Status | |
|---|---|---|
| firefox146 | --- | fixed |
People
(Reporter: hjones, Assigned: hjones)
References
(Blocks 1 open bug)
Details
(Whiteboard: [recomp])
Attachments
(1 file)
Currently it's not possible to wire up a functional moz-toggle via config-based settings. moz-toggle only emits a toggle event, not a change event which is what we're expecting in setting-group. We can fix this in one of two ways:
- either update
moz-toggleto emit achangeevent in addition to atoggleevent, or; - change
setting-groupto respond to atoggleevent in the same way it does to achangeevent
| Assignee | ||
Updated•9 months ago
|
Whiteboard: [recom
| Assignee | ||
Updated•9 months ago
|
Whiteboard: [recom → [recomp]
Updated•9 months ago
|
| Assignee | ||
Updated•9 months ago
|
Summary: Ensure setting-group element listens responds to toggle events → Ensure setting-group element responds to toggle events
| Assignee | ||
Comment 1•9 months ago
|
||
Updated•9 months ago
|
Assignee: nobody → hjones
Status: NEW → ASSIGNED
Pushed by hjones@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/eb04fcc25deb
https://hg.mozilla.org/integration/autoland/rev/7fbe426deecd
add a listener for toggle events to setting-group r=mstriemer
Comment 3•9 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
status-firefox146:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 146 Branch
Updated•9 months ago
|
QA Whiteboard: [qa-triage-done-c147/b146]
You need to log in
before you can comment on or make changes to this bug.
Description
•