1998435 - The fingerprinting protection state cleaner shouldn't clear the global zoom

Status: RESOLVED FIXED

(Toolkit :: Data Sanitization, defect, P2)

Description

[Pier Angelo Vendrame]

When clearing the fingerprinting state, the default zoom is also cleared: https://searchfox.org/firefox-main/rev/cb52781342cc905eda923d009fc0b678f3a8c8c6/toolkit/components/cleardata/ClearDataService.sys.mjs#458-468
While zoom can be used for linkability, we think that this is an accessibility setting that shouldn't be cleared in this way.

Comment 1

[Emma Zühlcke [:emz]]

I agree, that seems unexpected.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1975753

:fkilic, since you are the author of the regressor, bug 1975753, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Pier Angelo Vendrame]

Clearing the NI for Fatih, as we already reached the consensus to remove this.
I'll try to do it later today.

Comment 4

[Pier Angelo Vendrame]

Attachment: Bug 1998435 - Do not reset the default zoom when clearing the FFP state. r?#anti-tracking

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ebfba9ae402e
https://hg.mozilla.org/integration/autoland/rev/986cb25b838d
Do not reset the default zoom when clearing the FFP state. r=manuel

Comment 6

[Harshit Sohaney [:hsohaney]]

Setting as S2 due to accessibility severity

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/21fb33016fbf
https://hg.mozilla.org/integration/autoland/rev/41d7609a1566
Revert "Bug 1998435 - Do not reset the default zoom when clearing the FFP state. r=manuel" for causing failures at browser_bug1975753_site_specific_zoom_level.js.

Comment 8

[Atila Butkovits]

Backed out for causing failures at browser_bug1975753_site_specific_zoom_level.js.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/41d7609a1566094d930ee9072dde6ec098876d69

Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=Am7MBC6BSwqm5-TX8cq8eg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=linux%2C24.04%2Cdebug%2Cmochitests%2Cwith%2Cnetworking%2Con%2Csocket%2Cprocess%2Cenabled%2Ctest-linux2404-64%2Fdebug-mochitest-browser-chrome-spi-nw%2Cbc2&revision=de720bdc83de8e5acac19b3df26efa8c079bbb11

Failure log: https://treeherder.mozilla.org/logviewer?job_id=534628121&repo=autoland&task=Am7MBC6BSwqm5-TX8cq8eg.0&lineNumber=3083

Comment 9

[Pier Angelo Vendrame]

Oh! It seems setGlobal is async, but it can take an optional callback parameter.
Let me add that to promisify the change of global zoom.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5572b86e919a
https://hg.mozilla.org/integration/autoland/rev/a7700f6a3583
Do not reset the default zoom when clearing the FFP state. r=manuel

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a7700f6a3583

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:pierov, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox145 to wontfix.

For more information, please visit BugBot documentation.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Is this something we should uplift to ESR140?

Comment 14

[Pier Angelo Vendrame]

Yes please, let me create an uplift request.

Comment 15

[Phabricator Automation]

firefox-esr140 Uplift Approval Request

• User impact if declined: This patch fixes another patch that was uplifted and contains code which might unexpectedly reset an accessibility option. It will be useful to Tor Browser.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: -
• Risk associated with taking this patch: low
• Explanation of risk level: Unsupported configuration (RFP/FFP)
• String changes made/needed: No
• Is Android affected?: no

Comment 16

[Pier Angelo Vendrame]

Attachment: Bug 1998435 - Do not reset the default zoom when clearing the FFP state.

Original Revision: https://phabricator.services.mozilla.com/D271446

Comment 17

[Dianna Smith [:diannaS]]

does bug 1998730 have to be uplifted as well?

Comment 18

[Pier Angelo Vendrame]

No, it seems the Bug was created before the initial attempt was landed.
There's another bug to prevent potential TV failures (Bug 1999527), but as a matter of fact we've never hit those, so I don't think that needs to be uplifted either.

Comment 19

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr140/rev/26755db4d775