1998827 - Update descriptions for site exceptions buttons in about:preferences to count number of sites added

Status: ASSIGNED

(Firefox :: IP Protection, task, P1)

Description

[kpatenio]

Designs for settings UI overall: https://www.figma.com/design/l75lLbgf95PuVqNafzdvel/VPN---Firefox-Integration--Pilot?node-id=15691-47603&m=dev
Designs for count permutations: https://www.figma.com/design/l75lLbgf95PuVqNafzdvel/VPN---Firefox-Integration--Pilot?node-id=15704-131919&m=dev

Setup conditions:

• Be enrolled in our experiment
• Change browser.ipProtection.variant to "beta" to see about:preferences UI

Right now, our moz-box-buttons for Firefox VPN settings have the placeholder descriptions "No websites added yet".

• We should update the strings per the Figma spec.
• We set the l10n ids in https://searchfox.org/firefox-main/rev/e613f4df351a21871cfeadf7d5b4043ffad157b1/browser/components/preferences/main.js#1503,1515.
• The strings themselves are in https://searchfox.org/firefox-main/rev/e613f4df351a21871cfeadf7d5b4043ffad157b1/browser/locales-preview/ipProtection.ftl#91,111
• If we want more control over the buttons themselves, then we should look at https://searchfox.org/firefox-main/rev/e613f4df351a21871cfeadf7d5b4043ffad157b1/browser/components/preferences/privacy.js#1262,1283

We'll need to count the number of inclusions or exclusions, according to the current protection mode selected.

• Eg. if we added 2 exclusions, then the description for the "all" button should be reflected to display "2 websites"

• According to config based settings docs, we can pass in a l10nArgs to our string.

• As for actually counting the sites — I'm wondering if setting up getControlConfig for our button settings in privacy.js can help? In our controlConfig, we could try calling Services.perms (like here) or IPPExceptionsManager to read the number of exclusions / inclusions. This is something that I haven't fully thought out yet.

Comment 1

[kpatenio]

Attachment: Bug 1998827 — update site exclusions control to show the correct number of excluded sites. r=#ip-protection-reviewers!