1998890 - Copying a profile fails to transfer passwords, payments, and address data

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, defect, P1)

Description

[Simona Badau, Desktop QA]

Found in

• Nightly 146.0a1

Affected versions

• Nightly 146.0a1

Tested platforms

• Affected platforms: Ubuntu 24.04, macOS 15 and Windows 11 x64

Preconditions

• Ensure a switchable profile (Profile A) is created and contains saved passwords and autofill data such as payment methods and addresses.

Steps to reproduce

1. In Profile A - navigate to the Profiles panel and click on "Copy this profile" to create Profile B.
2. In Profile B - navigate to about:preferences#privacy and check the saved Passwords, Payments and "Addresses and More".

Expected result

• All the Passwords, Payments and Addresses from Profile A should be copied to Profile B.

Actual result

• The Passwords, Payments and Addresses are not copied to Profile B.

Regression range

• This is not a regression.

Comment 1

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1998890 - Copy profile should copy requiresEncryption=true data. r=#profiles-reviewers,#backup-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/28805b4930b0
https://hg.mozilla.org/integration/autoland/rev/ac42e3256a22
Copy profile should copy requiresEncryption=true data. r=profiles-reviewers,fchasen,jhirsch

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/ac42e3256a22

Comment 4

[Donal Meehan [:dmeehan]]

Fx146 is affected, but we are near the end of the Fx146 beta cycle. There is only one beta build left before RC week.
:niklas, does this need an uplift request, or can it ride the train with Fx147?

Comment 5

[Raluca Popovici, Desktop QA]

Verified as fixed on MacOS 13.2.1, Ubuntu 24.10 and Windows 11 using Nightly 147.0a1 treeherder build. The passwords, payments, and address data are copied.

Comment 6

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Users cannot copy passwords, addresses, and credit cards when using the copy profile feature. Users expect this data to be copied when using the copy profile feature. Including this data is a primary part of this feature.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: Already verified.
• Risk associated with taking this patch: low
• Explanation of risk level: This fixes the issue where passwords, addresses, and credit cards aren't copied by temporarily adding encryption if the backup service doesn't have encryption enabled. QA has also verified the fix and we have verified the fix with tests.
• String changes made/needed: No.
• Is Android affected?: no

Comment 7

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1998890 - Copy profile should copy requiresEncryption=true data.

Original Revision: https://phabricator.services.mozilla.com/D272314

Comment 8

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/e79b506b003e
https://hg.mozilla.org/releases/mozilla-beta/rev/dba9435fa6c7

Comment 9

[Raluca Popovici, Desktop QA]

Verified as fixed on MacOS 13.2.1, Ubuntu 24.10 and Windows 11 using Beta treeherder build(https://treeherder.mozilla.org/jobs?repo=mozilla-beta&selectedTaskRun=Mqhyu2kzQIaZ1bq02Smt0A.0). The passwords, payments, and address data are copied.