1998953 - Add more detailed logging to PromptListener when prompts are opened and closed

Status: RESOLVED FIXED

(Remote Protocol :: Agent, enhancement, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

At the moment we have very generic trace logs for the prompt listener class when prompts are getting opened and closed. These give no indication to which browsing context they belong, nor which kind of prompt it is. It would be helpful to have this extra information so that it can be used to investigate issues like bug 1630162 - where a newly opened prompt on application quit blocks the shutdown of Firefox.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1998953 - [remote] Improve logging when prompts are opened and closed.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1998953 - [remote] Directly return in async methods of PromptListener.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cfa8b20dfaae
https://hg.mozilla.org/integration/autoland/rev/5b29e65cc170
[remote] Directly return in async methods of PromptListener. r=jdescottes
https://github.com/mozilla-firefox/firefox/commit/21524f4c3422
https://hg.mozilla.org/integration/autoland/rev/943324320d28
[remote] Improve logging when prompts are opened and closed. r=jdescottes

Comment 4

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/5b29e65cc170
https://hg.mozilla.org/mozilla-central/rev/943324320d28