1999123 - Misplaced popups (Hamburger, Download, Tab Thumbnail) sometimes appear at top-left window corner

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect)

Description

[erosman [:erosman]]

For the last 3-4 upgrades, occasionally, Hamburger menu, download popup, and tab thumbnails appear misplaced on the far left.
I haven’t found a pattern to reproduce.
It might be Wayland related.

Note: The issue does not appear to affect addons' toolbar popups.

Ubuntu 24.04 Wayland
Maximised Nightly

Comment 1

[erosman [:erosman]]

Attachment: bug1999123-a.png

Comment 2

[erosman [:erosman]]

Attachment: bug1999123-b.png

Comment 3

[Martin Stránský [:stransky] (ni? me) (PTO till June 6)]

Can you please test latest nighly? May be dupe of Bug 1990483.
Thanks.

Comment 4

[erosman [:erosman]]

Bug is present in Nightly Build ID 20251109095540

Comment 5

[Martin Stránský [:stransky] (ni? me) (PTO till June 6)]

Okay please run on terminal with MOZ_LOG="Widget:5 WidgetPopup:5" env variable and attach the log here. for instance as:
MOZ_LOG="Widget:5 WidgetPopup:5" firefox > log.txt 2>&1
Thanks.

Comment 6

[erosman [:erosman]]

Bug is present in Nightly Build ID 20251110094323

I am not familiar with it.

• MOZ_LOG="Widget:5 WidgetPopup:5" firefox > log.txt 2>&1 launched standard Firefox, not Nightly
• Where would the log be?

Comment 7

[Martin Stránský [:stransky] (ni? me) (PTO till June 6)]

Ahh sorry, for nightly you need to use:

MOZ_LOG="Widget:5 WidgetPopup:5" ./firefox > log.txt 2>&1

run ./firefox from directory where nightly is located. There will be the log.txt file after that and this needs to be attached here.
Thanks.

Comment 8

[erosman [:erosman]]

I tried multiple times but that is all I get in log.txt.

[29039] Sandbox: CanCreateUserNamespace() unshare(CLONE_NEWPID): EPERM

Comment 9

[Denis Lisov]

Seeing misplaced popups sometimes too (no clear STR, currently at Nightly 2025-11-08). Will try to enable logging as requested above with about:logging and catch the problem.

Comment 10

[Denis Lisov]

Attachment: log-main-no_frac_scale-issue_at_104637.txt

This log includes a misplaced popup at around 10:46:37. I've filtered out all lines for "nsWindow::FractionalScaleFactor(): fractional scale 1.00" as there were hundreds of these per second.

Comment 11

[Kestrel]

Noticed this randomly with Nightly 146.0a1 since 2025-11-08 (possibly a few days before, related Bug 1990483 landed in 2025-11-05), Ubuntu 25.10 (Wayland), GNOME 49, single display, 100% scale, maximized and unmaximized windows. In the case of tab previews, the popup keeps reappearing at the top-left window corner as long as the mouse cursor doesn't hover over a different tab.

Comment 12

[Kestrel]

Attachment: MOZ_LOG="WidgetPopup:5" with misplaced tab hover preview

Log of it happening with tab hover preview.

Comment 13

[Martin Stránský [:stransky] (ni? me) (PTO till June 6)]

Thanks, there's the related part here:

2025-11-11 10:46:35.397100 UTC - [Parent 1577257: Main Thread]: D/WidgetPopup [7f01c5b11b00]: nsWindow::WaylandPopupHierarchyCalculatePositions()
2025-11-11 10:46:35.397101 UTC - [Parent 1577257: Main Thread]: D/WidgetPopup [7f01c5b11b00]:   popup [7f01c5b11b00] set parent window [7f0214defc00]
2025-11-11 10:46:35.397103 UTC - [Parent 1577257: Main Thread]: D/WidgetPopup [7f01c5b11b00]:   popup [7f01c5b11b00] bounds [699, 31] -> [288 x 97]
2025-11-11 10:46:35.397104 UTC - [Parent 1577257: Main Thread]: D/WidgetPopup [7f01c5b11b00]:   popup [7f01c5b11b00] layout [699, 31] -> [288 x 96]
2025-11-11 10:46:35.397106 UTC - [Parent 1577257: Main Thread]: D/WidgetPopup [7f01c5b11b00]:   popup [7f01c5b11b00] has toplevel as parent
2025-11-11 10:46:35.397107 UTC - [Parent 1577257: Main Thread]: D/WidgetPopup [7f01c5b11b00]:   popup [7f01c5b11b00] transformed popup coordinates from [0, 0] to [0, 0]
2025-11-11 10:46:35.397109 UTC - [Parent 1577257: Main Thread]: D/WidgetPopup [7f01c5b11b00]: nsWindow::WaylandPopupFitsToplevelWindow()
2025-11-11 10:46:35.397110 UTC - [Parent 1577257: Main Thread]: D/WidgetPopup [7f01c5b11b00]:   parent size 1920 x 1026
2025-11-11 10:46:35.397111 UTC - [Parent 1577257: Main Thread]: D/WidgetPopup [7f01c5b11b00]:   popup topleft 699, 31 size 288 x 97
2025-11-11 10:46:35.397112 UTC - [Parent 1577257: Main Thread]: D/WidgetPopup [7f01c5b11b00]:   fits 1
2025-11-11 10:46:35.397114 UTC - [Parent 1577257: Main Thread]: D/WidgetPopup [7f01c5b11b00]:   popup [7f01c5b11b00] matches layout [1] anchored [1] first popup [1] use move-to-rect 0
2025-11-11 10:46:35.397115 UTC - [Parent 1577257: Main Thread]: D/WidgetPopup [7f01c5b11b00]: nsWindow::WaylandPopupMove
2025-11-11 10:46:35.397116 UTC - [Parent 1577257: Main Thread]: D/WidgetPopup [7f01c5b11b00]:   original widget popup position [0, 0]
2025-11-11 10:46:35.397118 UTC - [Parent 1577257: Main Thread]: D/WidgetPopup [7f01c5b11b00]:   relative widget popup position [0, 0]
2025-11-11 10:46:35.397119 UTC - [Parent 1577257: Main Thread]: D/WidgetPopup [7f01c5b11b00]:   popup use move to rect 0
2025-11-11 10:46:35.397120 UTC - [Parent 1577257: Main Thread]: D/WidgetPopup [7f01c5b11b00]: nsWindow::WaylandPopupPrepareForMove()
2025-11-11 10:46:35.397121 UTC - [Parent 1577257: Main Thread]: D/WidgetPopup [7f01c5b11b00]:   type matches and we're not forced to hide it, quit.
2025-11-11 10:46:35.397123 UTC - [Parent 1577257: Main Thread]: D/WidgetPopup [7f01c5b11b00]: nsWindow::WaylandPopupMovePlain(0, 0)
2025-11-11 10:46:35.397127 UTC - [Parent 1577257: Main Thread]: D/WidgetPopup [7f01c5b11b00]: nsWindow::WaylandPopupHierarchyShowTemporaryHidden()
2025-11-11 10:46:35.397128 UTC - [Parent 1577257: Main Thread]: D/WidgetPopup [7f01c5b11b00]: Widget Popup Hierarchy:
2025-11-11 10:46:35.397131 UTC - [Parent 1577257: Main Thread]: D/WidgetPopup [7f01c5b11b00]:      Frame(7f0215975650) panel Panel/Utility nsWindow [7f01c5b11b00] Permanent 0 ContextMenu 0 Anchored 1 Visible 0 MovedByRect 0
2025-11-11 10:46:35.397137 UTC - [Parent 1577257: Main Thread]: D/WidgetPopup [7f01c5b11b00]: Layout Popup Hierarchy:
2025-11-11 10:46:35.397139 UTC - [Parent 1577257: Main Thread]: D/WidgetPopup [7f01c5b11b00]:      Frame(7f0215975650) panel Panel/Utility nsWindow [7f01c5b11b00] Permanent 0 ContextMenu 0 Anchored 1 Visible 0 MovedByRect 0
2025-11-11 10:46:35.397141 UTC - [Parent 1577257: Main Thread]: D/WidgetPopup [7f01c5b11b00]: nsWindow::ShowWaylandPopupWindow. Expected to see visible.
2025-11-11 10:46:35.397143 UTC - [Parent 1577257: Main Thread]: D/WidgetPopup [7f01c5b11b00]: nsWindow::WaylandPopupRemoveNegativePosition()
2025-11-11 10:46:35.397231 UTC - [Parent 1577257: Main Thread]: D/Widget moz_container_wayland_size_allocate [7f01c5b11b00] 0,0 -> 288 x 97

I wonder how we ended up with 0,0 position if layout/bounds positions are correct.

Comment 14

[Martin Stránský [:stransky] (ni? me) (PTO till June 6)]

Attachment: Bug 1999123 [Wayland] Don't consider popup explicitly moved if it's resized only r?emilio

Comment 15

[Martin Stránský [:stransky] (ni? me) (PTO till June 6)]

We should uplift it to 146.0.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/81bed30d4af0
https://hg.mozilla.org/integration/autoland/rev/a3c88977c891
[Wayland] Don't consider popup explicitly moved if it's resized only r=emilio

Comment 17

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a3c88977c891

Comment 18

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:stransky, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox146 to wontfix.

For more information, please visit BugBot documentation.

Comment 19

[Martin Stránský [:stransky] (ni? me) (PTO till June 6)]

Comment on attachment 9526117 [details]
Bug 1999123 [Wayland] Don't consider popup explicitly moved if it's resized only r?emilio

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Misplaced popups if popup was resized only and not placed explicitly.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We add another check for resize only to fix for Bug 1990483.
• String changes made/needed:
• Is Android affected?: No

Comment 20

[Dianna Smith [:diannaS]]

Comment on attachment 9526117 [details]
Bug 1999123 [Wayland] Don't consider popup explicitly moved if it's resized only r?emilio

Approved for 146.0b3

Comment 21

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/9f2ce95ecaf6
https://hg.mozilla.org/releases/mozilla-beta/rev/5a40168703f3

Comment 22

[Monica Chiorean]

I was able only to reproduce Bug 1990483 on an older build (Firefox Nightly 146.0a1 since 2025-11-04), but could not reproduce the issue described here, using Nightly from 2025-11-09.
Erosman, can you please confirm issue is fixed on latest Beta, and latest Nightly. Thank you.

Comment 23

[erosman [:erosman]]

I have not experienced on Nightly it since the fix.

Comment 24

[Monica Chiorean]

Marked as verified based on reporter's comment#23 and based on the fact that I could not reproduce it on latest beta builds.

Comment 25

[erosman [:erosman]]

There are other instances of misplaced popups. I left a note on #nightly:mozilla.org on Nov 21, but there has been no response.
The screenshots will follow, in case they are related to this bug.
One is for the Dev Tools Console Settings popup and the other for the context-menu popup.

Comment 26

[erosman [:erosman]]

Attachment: bug1999123-c.png

Comment 27

[erosman [:erosman]]

Attachment: bug1999123-d.png

Comment 28

[Martin Stránský [:stransky] (ni? me) (PTO till June 6)]

(In reply to erosman [:erosman] from comment #25)

There are other instances of misplaced popups. I left a note on #nightly:mozilla.org on Nov 21, but there has been no response.
The screenshots will follow, in case they are related to this bug.
One is for the Dev Tools Console Settings popup and the other for the context-menu popup.

Please file a new bug for it and needinfo me there.
Thanks!