1999166 - Newtab shortcuts feed is coupled with a few tests that are not obviously related to newtab or shortcuts

Status: NEW

(Firefox :: New Tab Page, defect)

Description

[Scott [:thecount] Downe]

When turning off topsites in tests, specifically when running this test ./mach marionette-test --gecko-log=- -vv browser/components/migration/tests/marionette/test_refresh_firefox.py, it starts to fail

This seems to have something to do with the getLinksWithDefaults in topsties feed being needed for the test "testResetEverything" in test_refresh_firefox.py. Looks like a bookmarks related coupling that's not obvious, and probably not great. I suspect it's an issue with the test itself, and not something users can hit, but I wouldn't rule anything out until I know more. Either way it's bee around for a long time, and likely harmless or a extreme edge case.

Ideally turning off shortcuts, the rest of the browser should work as expected, as well as tests unrelated to newtab should continue to pass.

I found this when making a pref to turn off all of newtab while running tests as needed, and some tests are showing that it's not that easy, and at the very least our tests can be fairly coupled with newtab in ways that are not obvious.

Comment 1

[Scott [:thecount] Downe]

A bit more investigating, and it looks it's the connection the shortcuts feed has with LinksCache.sys.mjs, which is referenced in getLinksWithDefaults, that seems to cause this test to be coupled with shortcuts.

Comment 2

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:thecount, could you have a look please?

For more information, please visit BugBot documentation.