19992 - Eliminate nsIMimeURLUtils

Status: VERIFIED FIXED

(MailNews Core :: MIME, defect, P3)

Description

[Ben Bucksch (:BenB)]

Necko and my new scanner class now have the same (and better functionality).
The scan functions had just 3 users, which I already changed to my new class.

What remains are the URL utility functions, which have newer counterparts in
Necko. I found only 2 users, which both proxy more calls through a function:
<http://lxr.mozilla.org/seamonkey/source/mailnews/compose/src/nsMsgCompUtils.cpp#1916>
and
<http://lxr.mozilla.org/seamonkey/source/mailnews/mime/src/mimemrel.cpp#349>.
mimehdrs.cpp includes nsMimeURLUtils, but seems not to use it. All other
references to nsIMimeURLUtils functions I found were either to Netlib or
commented out.

I tried to change the to functions to Necko and delete ns(I)MimeURLUtils.*, but
had problems with Necko and XPCOM.

I'll attach the state of my work, but it's not more than hints.

Comment 1

[Ben Bucksch (:BenB)]

Attachment: My try to replace nsMimeURLUtils with Necko

Comment 2

[Ben Bucksch (:BenB)]

The classes with use the scanner functions and with I was able to migrate are:
nsMsgSendPart.cpp, mimetpla.cpp and mimetpfl.cpp

Comment 3

[rhp (gone)]

Ben,
I'm a little confused here. If I made the changes that are in the patch, will
everything still work? The patch looks like a lot of code being removed.

- rhp

Comment 4

[Ben Bucksch (:BenB)]

rhp, no, please don't check this patch in. It will horribly break a lot of code.
That's why I assigned this to you: I was unable to complete that. However, the
patch (and my description on this bug) might be a good start.

I forgot to add a dependency on 19251. Done.

Comment 5

[rhp (gone)]

The replacement functions we need to use would be helpful here.

- rhp

Comment 6

[Ben Bucksch (:BenB)]

ParseURL (used in function nsMsgParseURL in nsMsgCompUtils.cpp):
You can create a new URL (nsIURL or nsStdURL?) with the string URL as spec and
the use the Get functions (GetHost etc.) to get the asked parts.

MakeAbsoluteURL (used in MakeAbsoluteURL in mimemrel.cpp):
You can use NS_MakeAbsoluteURL
(see
<http://lxr.mozilla.org/seamonkey/source/network/module/nsNetService.cpp#1169>
and <http://lxr.mozilla.org/seamonkey/source/network/public/nsIURL.h#119>) or,
if you have no access to that function, do the same what it does.

All other functions seem to be unused.

Comment 7

[rhp (gone)]

I've done some work on this but it is not as simple as it may seem. Many of the
Necko functions are not accessable outside of necko and the semantics of some
of these are different even though the name is the same.

I'll see what I can do.

- rhp

Comment 8

[Ben Bucksch (:BenB)]

Yes, I had similar problems. Set priority/severity as you like. Don't care about
the scanner funtions, I already threw them out.

Comment 9

[rhp (gone)]

This was taken care of when landing the big TXT - HTML conversion landing.

- rhp

Comment 10

[Ben Bucksch (:BenB)]

<http://lxr.mozilla.org/seamonkey/find?string=MimeURLUtils> should be prove
enough, right?

Comment 11

[lchiang]

thanks, Ben.