1999204 - nss: use optimized ARM64 crypto on Mac

Status: RESOLVED FIXED

(NSS :: Build, enhancement)

Description

[Lars Eggert [:lars]]

By providing the correct flag overrides. Should speed up some crypto operations considerably.

See https://github.com/Homebrew/homebrew-core/pull/252466

Comment 1

[Lars Eggert [:lars]]

Attachment: coreconf-Darwin.mk.patch

Comment 2

[John Schanck [:jschanck]]

I needed to use -arch arm64 to get this work with Clang 17 on an M4 mac. What compiler did you test it with?

Comment 3

[Lars Eggert [:lars]]

Homebrew clang version 21.1.5
Target: arm64-apple-darwin25.1.0
Thread model: posix
InstalledDir: /Volumes/mozdrone/opt/homebrew/Cellar/llvm/21.1.5/bin
Configuration file: /Volumes/mozdrone/opt/homebrew/etc/clang/arm64-apple-darwin25.cfg
System configuration file directory: /Volumes/mozdrone/opt/homebrew/etc/clang
User configuration file directory: /Users/lars/.config/clang

But it works with the Apple clang for me as well.

Comment 4

[John Schanck [:jschanck]]

I can't get it to work with -arch aarch64 with Apple clang or Homebrew clang. Compiler explorer also gives me an error: https://godbolt.org/z/MdxazzbTe

Maybe you're not building anything? Does it work after a make clean?

Comment 6

[John Schanck [:jschanck]]

Attachment: Bug 1999204 - fix CPU_ARCH setting for arm64 makefile builds. r=rrelyea

Comment 7

[Lars Eggert [:lars]]

I did HOMEBREW_NO_INSTALL_FROM_API=1 brew reinstall --build-from-source nss -v, which works fine with -arch aarch64. But when I try to do make nss_build_all, neither -arch aarch64 nor -arch arm64 succeed.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/nss/rev/a3c02501406e
fix CPU_ARCH setting for arm64 makefile builds. r=rrelyea