1999332 - Update googletest to new version 085af2cc08600bdb13827ca40261abcbe5048bb5 from 2025-11-08 10:53:26

Status: NEW

(Testing :: GTest, enhancement)

Description

[Update Bot]

This update covers 9 commits. Here are the overall diff statistics, and then the commit information.

---

third_party/googletest/googlemock/include/gmock/gmock-matchers.h | 14 ++++++-
third_party/googletest/googlemock/include/gmock/gmock-spec-builders.h | 8 ++--
third_party/googletest/googletest/include/gtest/gtest.h | 4 +-
third_party/googletest/googletest/src/gtest.cc | 18 +++++----
third_party/googletest/moz.yaml | 4 +-
5 files changed, 28 insertions(+), 20 deletions(-)

---

085af2cc08600bdb13827ca40261abcbe5048bb5 by Abseil Team <[e-mail]>

https://github.com/google/googletest/+/085af2cc08600bdb13827ca40261abcbe5048bb5
Authored: 2025-11-08 02:52:45 -0800
Committed: 2025-11-08 02:53:26 -0800

Automated rollback of commit 37678c92fb183b148163dd173430b4ab88586a26.

PiperOrigin-RevId: 829765029
Change-Id: Ia5534b109e0abfd17a74d89ce58d6588a6255f94

Files Modified:

• googletest/src/gtest.cc

---

37678c92fb183b148163dd173430b4ab88586a26 by Abseil Team <[e-mail]>

https://github.com/google/googletest/+/37678c92fb183b148163dd173430b4ab88586a26
Authored: 2025-11-07 20:49:55 -0800
Committed: 2025-11-07 20:50:29 -0800

gtest_fail_if_no_test_selected: Rephrase error message.

Sharded tests interact awkwardly with --gtest_fail_if_no_test_selected, but we
can't speak clearly enough to the use cases to complicate the mental model, so
instead we attempt to clarify the simplest approach to debugging a single test
when sharding and --gtest_fail_if_no_test_selected are both in use: unset the
flag.

PiperOrigin-RevId: 829686145
Change-Id: I9ebbddc6e7537feefe2a3707fd323fc9132b99d1

Files Modified:

• googletest/src/gtest.cc

---

dedab73a689243743c868748ba7f8c4b03316f89 by David Pizzuto <[e-mail]>

https://github.com/google/googletest/+/dedab73a689243743c868748ba7f8c4b03316f89
Authored: 2025-11-07 16:02:11 -0800
Committed: 2025-11-07 16:02:48 -0800

gtest_fail_if_no_test_selected: Rephrase error message.

Sharded tests interact awkwardly with --gtest_fail_if_no_test_selected, but we
can't speak clearly enough to the use cases to complicate the mental model, so
instead we attempt to clarify the simplest approach to debugging a single test
when sharding and --gtest_fail_if_no_test_selected are both in use: unset the
flag.

PiperOrigin-RevId: 829609266
Change-Id: I090d5bfac979171532249e9312feef8d9aad5f16

Files Modified:

• googletest/src/gtest.cc

---

6ec14dfd8c409d05fba94e18e3a02df35b874353 by Abseil Team <[e-mail]>

https://github.com/google/googletest/+/6ec14dfd8c409d05fba94e18e3a02df35b874353
Authored: 2025-10-31 13:55:24 -0700
Committed: 2025-10-31 13:56:00 -0700

Modernize example of combining matchers.

As of C++14 an ordinary function can have an auto return type.

PiperOrigin-RevId: 826617761
Change-Id: I2ceecc8430643c0ac7843fb216b5a117cfe10ab3

Files Modified:

• docs/gmock_cook_book.md

---

17d335d7c7f15d989516255471c3d7f5d204308d by Justin Bassett <[e-mail]>

https://github.com/google/googletest/+/17d335d7c7f15d989516255471c3d7f5d204308d
Authored: 2025-10-30 21:51:50 -0700
Committed: 2025-10-30 21:53:01 -0700

Remove short-circuiting from AllOf, for better failure messages

For EXPECT_THAT matcher usage, showing only the first failure meant
that users would sometimes have to make a fix and run the test again
only to notice that there's another failure. It's better to show more
failures so that the user can fix several issues in one go.

In practice, very little code actually wants the short circuiting here,
only a handful of cases with custom matchers used like
AllOf(BoundsCheck(), UncheckedAccess()). These cases are fixable by
refactoring UncheckedAccess() to instead also apply a bounds check to
fail the matcher rather than crash. Notably, this change doesn't affect
AnyOf, so another workaround is to change AllOf(m1, m2, ...) into
Not(AnyOf(Not(m1), Not(m2), ...)).

PiperOrigin-RevId: 826316273
Change-Id: Ie8186f75c10443d8da35b5d07b6a8cd9ae85b451

Files Modified:

• googlemock/include/gmock/gmock-matchers.h
• googlemock/test/gmock-matchers-arithmetic_test.cc
• googlemock/test/gmock-matchers-comparisons_test.cc

---

4fe3307fb2d9f86d19777c7eb0e4809e9694dde7 by Derek Mauro <[e-mail]>

https://github.com/google/googletest/+/4fe3307fb2d9f86d19777c7eb0e4809e9694dde7
Authored: 2025-10-30 10:10:42 -0700
Committed: 2025-10-30 10:11:17 -0700

macOS CI: Move the Bazel vendor_dir to ${HOME} to workaround a Bazel issue where it does not work when it is in ${TMP} and also fix the quoting which was causing it to incorrectly receive the argument

https://github.com/bazelbuild/bazel/issues/27156

PiperOrigin-RevId: 826083231
Change-Id: If8f069c42c62434893db27bdaae0b0e25b67839d

Files Modified:

• ci/macos-presubmit.sh

---

b2b9072ecbe874f5937054653ef8f2731eb0f010 by Abseil Team <[e-mail]>

https://github.com/google/googletest/+/b2b9072ecbe874f5937054653ef8f2731eb0f010
Authored: 2025-10-16 06:31:04 -0700
Committed: 2025-10-16 06:31:44 -0700

Mark InternalDefaultActionSetAt as nodiscard.

PiperOrigin-RevId: 820207225
Change-Id: I8e053f724c18b466bd287f80a720542a535615d2

Files Modified:

• googlemock/include/gmock/gmock-spec-builders.h
• googlemock/test/gmock-internal-utils_test.cc
• googlemock/test/gmock-spec-builders_test.cc

---

e17e37a1151a47d6e8089f2e9a78921ac022a511 by Abseil Team <[e-mail]>

https://github.com/google/googletest/+/e17e37a1151a47d6e8089f2e9a78921ac022a511
Authored: 2025-10-15 21:01:25 -0700
Committed: 2025-10-15 21:01:54 -0700

Automated Code Change

PiperOrigin-RevId: 820039898
Change-Id: I910d8ec41198794e7344a2d79566a19243532251

Files Modified:

• googlemock/test/gmock-actions_test.cc
• googlemock/test/gmock-matchers-arithmetic_test.cc
• googlemock/test/gmock-matchers-containers_test.cc
• googlemock/test/gmock-matchers-misc_test.cc

---

8dbd60f7d5f88aca74ef76f4dd5258d35c324199 by Abseil Team <[e-mail]>

https://github.com/google/googletest/+/8dbd60f7d5f88aca74ef76f4dd5258d35c324199
Authored: 2025-10-13 13:43:39 -0700
Committed: 2025-10-13 13:44:23 -0700

Restore the documentation of AnyWith<T>(m) in the matchers reference.

PiperOrigin-RevId: 818813216
Change-Id: If4cb881a61a05b2c6634aa0d5ee66ea2962f168a

Files Modified:

• docs/reference/matchers.md

---

Comment 1

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=017a1faec2aae55cd2e4c0c1408cda2206fb6e18

Comment 2

[Update Bot]

Attachment: Bug 1999332 - Update googletest to 085af2cc08600bdb13827ca40261abcbe5048bb5

Comment 3

[Update Bot]

Attachment: Bug 1999332 - Apply mozilla patches for googletest

Comment 4

[Update Bot]

All jobs completed, we found the following issues.

Known Issues:

• browser/components/sessionstore/test/browser_sessionStorage.js
  - test-linux2404-64/opt-mochitest-browser-chrome-spi-nw-5 (bFCfUAKwRui8iErTUEnMLw)

• toolkit/mozapps/extensions/test/xpinstall/browser_required_useractivation.js
  - test-linux2404-64/opt-mochitest-browser-chrome-spi-nw-7 (aN66QaJxT3aCVNFWgdjrZg)

These failures may mean that the library update succeeded; you'll need to review
them yourself and decide. If there are lint failures, you will need to fix them in
a follow-up patch. (Or ignore the patch I made, and recreate it yourself with
./mach vendor third_party/googletest/moz.yaml.)

In either event, I have done all I can, so you will need to take it from here.
When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.