1999381 - Syntax error in parsetm.c (affects NSPR 4.38.1 and NSPR 4.36.1)

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[Kai Engert [:KaiE:]]

Apologies, when I tried to avoid code duplication, I introduced a compiler error in the new parsetm.c test from bug 1999105

(Why didn't I run into that error when I locally build it...)

The library code should be unaffected, because Firefox or Thunderbird don't build the NSPR tests.

However, NSS is affected, because it builds all of NSPR.

Comment 1

[Kai Engert [:KaiE:]]

Attachment: Bug 1999381 - Fix build failure in parsetm.c on some platforms. r=wtc,#nss-reviewers

Comment 2

[Kai Engert [:KaiE:]]

Wan-Teh, the attached patch in phabricator restores your original approach for the test code.

(I had attempted to optimize by avoiding the repetitive use of the constant, and that build for me on Linux, but it fails to build on some platforms.)

Does this patch look ok to you?

Comment 3

[Kai Engert [:KaiE:]]

try build with this patch is running here:
https://treeherder.mozilla.org/jobs?repo=nss-try&revision=41bc0c3dcb2246af2dfb3af2edb9ba7056b08d9b

Comment 4

[Kai Engert [:KaiE:]]

tip:
https://hg-edge.mozilla.org/projects/nspr/rev/186460961cdf0b0ce55340dcdf95fc8219fd6b63

4.38.2:
https://hg-edge.mozilla.org/projects/nspr/rev/6d2a51e050ffc6a7e27786fd7cdd42e4ca60e5f3

4.36.2:
https://hg-edge.mozilla.org/projects/nspr/rev/45db9eaf29e9f928d1afb1ce1d3f53c4eae9a661