Closed
Bug 1999478
Opened 1 year ago
Closed 1 year ago
riscv64: DEBUG_PRINTF not disabled on non-DEBUG builds
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
147 Branch
| Tracking | Status | |
|---|---|---|
| firefox147 | --- | fixed |
People
(Reporter: csmantle, Assigned: csmantle)
References
(Blocks 1 open bug)
Details
Attachments
(1 external file)
Currently, DEBUG_PRINTF is unconditionally compiled even on non-DEBUG builds (^1). This could hurt performance, as most invocations of this macro occur on hot paths.
| Assignee | ||
Updated•1 year ago
|
Assignee: nobody → webmaster
| Assignee | ||
Comment 1•1 year ago
•
|
||
The shrink in binary size proves the effect of this change, which also
reveals that the original code and its associated format strings are not
eliminated as dead.
After:
$ size ./obj/dist/bin/js
text data bss dec hex filename
77153608 3045625 10363484 90562717 565e09d ./obj/dist/bin/js
Before:
$ size ./obj/dist/bin/js
text data bss dec hex filename
77166598 3050169 10362748 90579515 566223b ./obj/dist/bin/js
Pushed by jdemooij@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/f80645835e96
https://hg.mozilla.org/integration/autoland/rev/06be62b5ac53
[riscv64] Hide DEBUG_PRINTF behind a gate to avoid codegen on non-DEBUG builds. r=jandem
Comment 3•1 year ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox147:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 147 Branch
Updated•11 months ago
|
QA Whiteboard: [qa-triage-done-c148/b147]
| Assignee | ||
Updated•11 months ago
|
Blocks: sm-riscv64
You need to log in
before you can comment on or make changes to this bug.
Description
•