1999558 - Commit message cut off (last character missing if commit message contains no line break)

Status: RESOLVED FIXED

(Testing :: PerfCompare, defect, P3)

Description

[Markus Stange [:mstange]]

Example: https://perf.compare/compare-results?baseRev=f37fd7e1c1d049641ac1693c93d450f9927d0317&baseRepo=try&newRev=3a648c55b0d2262c96c50afb2ea46e5894ceac34&newRepo=try&framework=15

PerfHerder displays "warmup classifie" without the "r" at the end even though the actual commit message is "warmup classifier".

Looks like getLatestCommitMessage doesn't handle the case where lastUsefulRevision.comments.indexOf('\n') returns -1.
https://github.com/mozilla/perfcompare/blob/cd19ffee93fb5fcf22019bea96089ac79c7c7186/src/utils/helpers.ts#L21-L24

Comment 1

[Greg Mierzwinski [:sparky]]

Attachment: Screenshot of issue with commit message

Link to patch that causes this issue: https://hg-edge.mozilla.org/try/rev/5a2e53ca502c56632d7f15f069bf65cc008d0695

Comment 2

[Alex [:moijes12]]

Attachment: GitHub Pull Request

Attaching PR for fix

Comment 3

[Alex [:moijes12]]

Attachment: Screenshot of fix in local environment

Comment 4

[Alex [:moijes12]]

Why am I still seeing this issue even though the PR is merged ? Is the update not deployed on the prod instance yet ?

Comment 5

[Kala Severe [:kala]]

Yes, this issue has been resolved with checked in PR: https://github.com/mozilla/perfcompare/commit/fda1fb2bee4d820ef35b604a1ee0fca079b7fbf3. Closing now.

Comment 6

[Markus Stange [:mstange]]

I agree with comment 4 - it doesn't appear to be fixed in production. Kala, could you answer the question in comment 4?

Comment 7

[Kala Severe [:kala]]

My apologies, reopening because it hasn't been merged into production yet. We'll do a deploy to prod next week and it will be checked in.

Comment 8

[Markus Stange [:mstange]]

Makes sense, thanks!

Comment 9

[Kala Severe [:kala]]

Deployed to prod!