Closed Bug 1999568 Opened 11 months ago Closed 11 months ago

[wpt-sync] Sync PR 55986 - [css-values] Reduce viewport units when scrollbars are unconditional

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
147 Branch
Tracking Flags:
Tracking Status
firefox147 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 55986 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/55986
Details from upstream follow.

David Grogan <dgrogan@chromium.org> wrote:

[css-values] Reduce viewport units when scrollbars are unconditional

When the root element has unconditional scrollbars (i.e.
overflow:scroll), we reduce the viewport units accordingly. All viewport
units are affected.

The modified units need to affect properties specified on the root
element, so we resolve the properties that can affect scrollbars early.

Note this change is not yet complete. The dynamic test fails, scrollbar
gutters aren't respected yet, and a few other small things.

Bug: 354751900
Change-Id: I51653d0491a32f86539e219a3e99a6eead3c7dc4
Reviewed-on: https://chromium-review.googlesource.com/7098882
WPT-Export-Revision: 2d035fc4e8a1eed0d08b595187b64bb10925a794

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 8 tests

Status Summary

Firefox

OK : 3
PASS: 3
FAIL: 38

Chrome

OK : 3
PASS: 3
FAIL: 38

Safari

OK : 3
PASS: 3
FAIL: 38

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/css-values/viewport-units-scrollbars-compute.html [wpt.fyi]
    • 100vw computes to 185px: FAIL (Chrome: FAIL, Safari: FAIL)
    • 100vi computes to 185px: FAIL (Chrome: FAIL, Safari: FAIL)
    • 100vmax computes to 185px: FAIL (Chrome: FAIL, Safari: FAIL)
    • 100svw computes to 185px: FAIL (Chrome: FAIL, Safari: FAIL)
    • 100svi computes to 185px: FAIL (Chrome: FAIL, Safari: FAIL)
    • 100svmax computes to 185px: FAIL (Chrome: FAIL, Safari: FAIL)
    • 100lvw computes to 185px: FAIL (Chrome: FAIL, Safari: FAIL)
    • 100lvi computes to 185px: FAIL (Chrome: FAIL, Safari: FAIL)
    • 100lvmax computes to 185px: FAIL (Chrome: FAIL, Safari: FAIL)
    • 100dvw computes to 185px: FAIL (Chrome: FAIL, Safari: FAIL)
    • 100dvi computes to 185px: FAIL (Chrome: FAIL, Safari: FAIL)
    • 100dvmax computes to 185px: FAIL (Chrome: FAIL, Safari: FAIL)
    • 100vh computes to 85px: FAIL (Chrome: FAIL, Safari: FAIL)
    • 100vb computes to 85px: FAIL (Chrome: FAIL, Safari: FAIL)
    • 100vmin computes to 85px: FAIL (Chrome: FAIL, Safari: FAIL)
    • 100svh computes to 85px: FAIL (Chrome: FAIL, Safari: FAIL)
    • 100svb computes to 85px: FAIL (Chrome: FAIL, Safari: FAIL)
    • 100svmin computes to 85px: FAIL (Chrome: FAIL, Safari: FAIL)
    • 100lvh computes to 85px: FAIL (Chrome: FAIL, Safari: FAIL)
    • 100lvb computes to 85px: FAIL (Chrome: FAIL, Safari: FAIL)
    • 100lvmin computes to 85px: FAIL (Chrome: FAIL, Safari: FAIL)
    • 100dvh computes to 85px: FAIL (Chrome: FAIL, Safari: FAIL)
    • 100dvb computes to 85px: FAIL (Chrome: FAIL, Safari: FAIL)
    • 100dvmin computes to 85px: FAIL (Chrome: FAIL, Safari: FAIL)
    • 1dvw computes to 1.84375px: FAIL (Chrome: FAIL, Safari: FAIL)
    • 10dvw computes to 18.5px: FAIL (Chrome: FAIL, Safari: FAIL)
    • 1dvh computes to 0.84375px: FAIL (Chrome: FAIL, Safari: FAIL)
    • 10dvh computes to 8.5px: FAIL (Chrome: FAIL, Safari: FAIL)
    • calc(1dvw + 1dvw) computes to 3.6875px: FAIL (Chrome: FAIL, Safari: FAIL)
    • calc(1dvw + 1dvh) computes to 2.6875px: FAIL (Chrome: FAIL, Safari: FAIL)
    • calc(1dvw + 100px) computes to 101.844px: FAIL (Chrome: FAIL, Safari: FAIL)
    • max(1svw, 1svh) computes to 1.84375px: FAIL (Chrome: FAIL, Safari: FAIL)
    • min(1lvw, 1lvh) computes to 0.84375px: FAIL (Chrome: FAIL, Safari: FAIL)
    • calc(1dvw + 10%) computes to 10.3438px: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-values/viewport-units-scrollbars-root-properties-001.html [wpt.fyi]
    • vw has had the overflow-y scrollbar width removed: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-values/viewport-units-scrollbars-dynamic-001.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-values/viewport-units-scrollbars-scroll-vw-001.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-values/viewport-units-scrollbars-scroll-vw-002.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)

https://hg.mozilla.org/mozilla-central/rev/0b88f9f64d6d
https://hg.mozilla.org/mozilla-central/rev/28d3fe6dea03

Status: NEW → RESOLVED
Closed: 11 months ago
status-firefox147: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 147 Branch
You need to log in before you can comment on or make changes to this bug.