1999623 - Remove some more view code.

Status: RESOLVED FIXED

(Core :: Web Painting, task)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1999623 - Remove more view code. r=#layout,tnikkel

Remove and simplify some view-using code:

• Add nsIFrame::GetOwnWidget() to get an nsIWidget rather than doing
  menupopup-or-view.
• Move widget invalidation to the only place it's used.
• Don't deal with reentrant paints. Assert more strongly.
• Move SetView only to ViewportFrame.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1999623 - Remove view to widget offset. r=#layout,tnikkel

View origin is (0, 0) always now.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e0b9d3d67032
https://hg.mozilla.org/integration/autoland/rev/cbe976f12953
Remove view to widget offset. r=tnikkel,layout-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b29a50ebafaf
https://hg.mozilla.org/integration/autoland/rev/8b0c43812dc3
Revert "Bug 1999623 - Remove view to widget offset. r=tnikkel,layout-reviewers" for causing build bustages in nsLayoutUtils.cpp.

Comment 5

[Serban Stanca [:SerbanS]]

Reverted this because it was causing build bustages in nsLayoutUtils.cpp.

• Revert link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/layout/base/nsLayoutUtils.cpp:X:21: error: no member named 'ViewToWidgetOffset' in 'nsView'

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/05318948d540
https://hg.mozilla.org/integration/autoland/rev/a1b66ec4236b
Remove more view code. r=tnikkel,layout-reviewers
https://github.com/mozilla-firefox/firefox/commit/857fc08db7a3
https://hg.mozilla.org/integration/autoland/rev/cd9960288222
Remove view to widget offset. r=tnikkel,layout-reviewers
https://github.com/mozilla-firefox/firefox/commit/4e7ded733fcb
https://hg.mozilla.org/integration/autoland/rev/518a081b1de6
1999627: apply code formatting via Lando

Comment 7

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/a1b66ec4236b
https://hg.mozilla.org/mozilla-central/rev/cd9960288222
https://hg.mozilla.org/mozilla-central/rev/518a081b1de6