Closed
Bug 1999664
Opened 2 months ago
Closed 1 month ago
Remove unused STL header inclusion
Categories
(Core :: General, task)
Core
General
Tracking
()
RESOLVED
FIXED
148 Branch
| Tracking | Status | |
|---|---|---|
| firefox148 | --- | fixed |
People
(Reporter: sergesanspaille, Assigned: sergesanspaille)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
Some STL header are big. On my config,
$ echo '#include <algorithm>' | clang++ -xc++ - -E | wc -l
17361
This impacts compilation time, so it would be good to remoe unused inclusion of those ehaders and avoid regressing on it.
|
Assignee | |
Comment 1•2 months ago
|
||
|
||
Updated•2 months ago
|
Attachment #9527662 -
Attachment description: Bug 1999664 - Add C++ standard library includes linter r=ahal → Bug 1999664 - New Linter - ensure we don't include unnecessary C++ standard headers r=ahal!
|
|
Assignee | |
Comment 2•1 month ago
|
||
Pushed by sguelton@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/2dd82727f6aa
https://hg.mozilla.org/integration/autoland/rev/78fedd294876
Remove remaining unused STL headers r=emilio,media-playback-reviewers,padenot
https://github.com/mozilla-firefox/firefox/commit/05983f9b8d52
https://hg.mozilla.org/integration/autoland/rev/69bfd9cf909e
New Linter - ensure we don't include unnecessary C++ standard headers r=ahal
|
||
Comment 4•1 month ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/78fedd294876
https://hg.mozilla.org/mozilla-central/rev/69bfd9cf909e
Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox148:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 148 Branch
|
||
Updated•22 days ago
|
QA Whiteboard: [qa-triage-done-c149/b148]
You need to log in
before you can comment on or make changes to this bug.
Description
•