199981 - cast warnings in necko/cache

Status: RESOLVED WORKSFORME

(Core :: Networking: Cache, defect)

Description

[gordon]

Originally submitted in bug 198789:



User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b)
Gecko/20030210
Build Identifier: Mozilla/5.0 Version 1.3, attempted build under HP-UX with HP
compilers/linkers

Building under HP-UX 11.00/32-bit results in the following warnings, best
displayed with fixed-width font:

Warning 749: "nsCacheEntry.cpp", line 508 # The cast from 'PLDHashEntryHdr *' to
 'nsCacheEntryHashTableEntry *' is performed as a 'reinterpret_cast'. This opera
tion is non-portable and potentially unsafe.
            result = ((nsCacheEntryHashTableEntry *)hashEntry)->cacheEntry;
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Warning 749: "nsCacheEntry.cpp", line 528 # The cast from 'PLDHashEntryHdr *' to
 'nsCacheEntryHashTableEntry *' is performed as a 'reinterpret_cast'. This opera
tion is non-portable and potentially unsafe.
        ((nsCacheEntryHashTableEntry *)hashEntry)->cacheEntry = cacheEntr
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Warning 749: "nsCacheEntry.cpp", line 566 # The cast from 'PLDHashEntryHdr *' to
 'nsCacheEntryHashTableEntry *' is performed as a 'reinterpret_cast'. This opera
tion is non-portable and potentially unsafe.
        nsCacheEntry *cacheEntry = ((nsCacheEntryHashTableEntry *)hashEntry)->ca
cheEntry;
                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Warning 749: "nsCacheEntry.cpp", line 577 # The cast from 'PLDHashEntryHdr *' to
 'nsCacheEntryHashTableEntry *' is performed as a 'reinterpret_cast'. This opera
tion is non-portable and potentially unsafe.
        nsCacheEntry *cacheEntry = ((nsCacheEntryHashTableEntry *)hashEntry)->ca
cheEntry;
                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Warning 749: "nsCacheEntry.cpp", line 594 # The cast from 'const PLDHashEntryHdr
 *' to 'nsCacheEntryHashTableEntry *' is performed as a 'reinterpret_cast'. This
 operation is non-portable and potentially unsafe.
        nsCacheEntry *cacheEntry = ((nsCacheEntryHashTableEntry *)hashEntry)->ca
cheEntry;
                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Warning 749: "nsCacheEntry.cpp", line 605 # The cast from 'PLDHashEntryHdr *' to
 'nsCacheEntryHashTableEntry *' is performed as a 'reinterpret_cast'. This opera
tion is non-portable and potentially unsafe.
        ((nsCacheEntryHashTableEntry *)to)->cacheEntry =
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Warning 749: "nsCacheEntry.cpp", line 606 # The cast from 'const PLDHashEntryHdr
 *' to 'nsCacheEntryHashTableEntry *' is performed as a 'reinterpret_cast'. This
 operation is non-portable and potentially unsafe.
            ((nsCacheEntryHashTableEntry *)from)->cacheEntry;
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Warning 749: "nsCacheEntry.cpp", line 614 # The cast from 'PLDHashEntryHdr *' to
 'nsCacheEntryHashTableEntry *' is performed as a 'reinterpret_cast'. This opera
tion is non-portable and potentially unsafe.
        ((nsCacheEntryHashTableEntry *)hashEntry)->cacheEntry = 0;
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Warning 749: "nsCacheMetaData.cpp", line 102 # The cast from 'PLDHashEntryHdr *'
 to 'nsCacheMetaDataHashTableEntry *' is performed as a 'reinterpret_cast'. This
 operation is non-portable and potentially unsafe.
            result = ((nsCacheMetaDataHashTableEntry *)hashEntry)->value;
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Warning 749: "nsCacheMetaData.cpp", line 126 # The cast from 'PLDHashEntryHdr *'
 to 'nsCacheMetaDataHashTableEntry *' is performed as a 'reinterpret_cast'. This
 operation is non-portable and potentially unsafe.
        metaEntry = (nsCacheMetaDataHashTableEntry *)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Warning 749: "nsCacheMetaData.cpp", line 218 # The cast from 'PLDHashEntryHdr *'
 to 'nsCacheMetaDataHashTableEntry *' is performed as a 'reinterpret_cast'. This
 operation is non-portable and potentially unsafe.
        return ((nsCacheMetaDataHashTableEntry *)hashEntry)->key;
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Warning 749: "nsCacheMetaData.cpp", line 236 # The cast from 'const PLDHashEntry
Hdr *' to 'nsCacheMetaDataHashTableEntry *' is performed as a 'reinterpret_cast'
. This operation is non-portable and potentially unsafe.
        nsCString * entryKey = ((nsCacheMetaDataHashTableEntry *)hashEntry)->key
;
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Warning 749: "nsCacheMetaData.cpp", line 248 # The cast from 'PLDHashEntryHdr *'
 to 'nsCacheMetaDataHashTableEntry *' is performed as a 'reinterpret_cast'. This
 operation is non-portable and potentially unsafe.
        ((nsCacheMetaDataHashTableEntry *)to)->key =
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Warning 749: "nsCacheMetaData.cpp", line 249 # The cast from 'const PLDHashEntry
Hdr *' to 'nsCacheMetaDataHashTableEntry *' is performed as a 'reinterpret_cast'
. This operation is non-portable and potentially unsafe.
            ((nsCacheMetaDataHashTableEntry *)from)->key;
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Warning 749: "nsCacheMetaData.cpp", line 250 # The cast from 'PLDHashEntryHdr *'
 to 'nsCacheMetaDataHashTableEntry *' is performed as a 'reinterpret_cast'. This
 operation is non-portable and potentially unsafe.
        ((nsCacheMetaDataHashTableEntry *)to)->value =
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Warning 749: "nsCacheMetaData.cpp", line 251 # The cast from 'const PLDHashEntry
Hdr *' to 'nsCacheMetaDataHashTableEntry *' is performed as a 'reinterpret_cast'
. This operation is non-portable and potentially unsafe.
            ((nsCacheMetaDataHashTableEntry *)from)->value;
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Warning 749: "nsCacheMetaData.cpp", line 259 # The cast from 'PLDHashEntryHdr *'
 to 'nsCacheMetaDataHashTableEntry *' is performed as a 'reinterpret_cast'. This
 operation is non-portable and potentially unsafe.
        ((nsCacheMetaDataHashTableEntry *)hashEntry)->key      = 0;
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Warning 749: "nsCacheMetaData.cpp", line 260 # The cast from 'PLDHashEntryHdr *'
 to 'nsCacheMetaDataHashTableEntry *' is performed as a 'reinterpret_cast'. This
 operation is non-portable and potentially unsafe.
        ((nsCacheMetaDataHashTableEntry *)hashEntry)->value    = 0;
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Warning 749: "nsCacheMetaData.cpp", line 281 # The cast from 'PLDHashEntryHdr *'
 to 'nsCacheMetaDataHashTableEntry *' is performed as a 'reinterpret_cast'. This
 operation is non-portable and potentially unsafe.
        nsCacheMetaDataHashTableEntry* hashEntry = (nsCacheMetaDataHashTableEntr
y *)hdr;
                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
^^^^
Warning 749: "nsCacheMetaData.cpp", line 294 # The cast from 'PLDHashEntryHdr *'
 to 'nsCacheMetaDataHashTableEntry *' is performed as a 'reinterpret_cast'. This
 operation is non-portable and potentially unsafe.
        nsCacheMetaDataHashTableEntry* hashEntry = (nsCacheMetaDataHashTableEntr
y *)hdr;
                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
^^^^
Warning 749: "nsCacheMetaData.cpp", line 319 # The cast from 'PLDHashEntryHdr *'
 to 'nsCacheMetaDataHashTableEntry *' is performed as a 'reinterpret_cast'. This
 operation is non-portable and potentially unsafe.
        nsCacheMetaDataHashTableEntry *entry = (nsCacheMetaDataHashTableEntry *)
hdr;
                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Warning 749: "nsCacheMetaData.cpp", line 332 # The cast from 'PLDHashEntryHdr *'
 to 'nsCacheMetaDataHashTableEntry *' is performed as a 'reinterpret_cast'. This
 operation is non-portable and potentially unsafe.
        nsCacheMetaDataHashTableEntry *entry   = (nsCacheMetaDataHashTableEntry
*)hdr;
                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
^^
Warning 749: "nsCacheService.cpp", line 1502 # The cast from 'PLDHashEntryHdr *'
 to 'nsCacheEntryHashTableEntry *' is performed as a 'reinterpret_cast'. This op
eration is non-portable and potentially unsafe.
        nsCacheEntry * entry = ((nsCacheEntryHashTableEntry *)hdr)->cacheEntry;
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Warning 749: "nsCacheService.cpp", line 1533 # The cast from 'PLDHashEntryHdr *'
 to 'nsCacheEntryHashTableEntry *' is performed as a 'reinterpret_cast'. This op
eration is non-portable and potentially unsafe.
        nsCacheEntry * entry = ((nsCacheEntryHashTableEntry *)hdr)->cacheEntry;
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Warning 749: "nsDiskCacheBinding.cpp", line 101 # The cast from 'nsDerivedSafe<n
sISupports> *' to 'nsDiskCacheBinding *' is performed as a 'reinterpret_cast'. T
his operation is non-portable and potentially unsafe.
        return (nsDiskCacheBinding *)data.get();
               ^^^^^^^^^^^^^^^^^^^^^^

Comment 1

[Atul Aggarwal]

I could not see any warning reported by bug in mac, windows and linux builds (in nightly builds).
Hence closing the bug.