1999824 - Use requestInterrupt() for capturing OOM stack trace

Status: NEW

(Core :: JavaScript Engine, enhancement, P2)

Description

[Bryan Thrall [:bthrall]]

It would be much less risky to use JSContext::requestInterrupt() when handling OOM, then capture the stack trace during the interrupt (which we already know is safe). It looks like we already check interrupts when exceptions happen.

The main concern with the interrupt-based approach is the stack trace might not be as accurate, since it will be captured during the interrupt instead of exactly when the OOM happens. However, this might not be a problem since the OOM is an exception, so there won't be much code executing between when the exception is thrown and when it is handled.

Comment 1

[Jan de Mooij [:jandem]]

I like this idea. It also means we can put back some of the #ifdefs for AutoUnsafeCallWithABI to avoid overhead in release builds.