1999989 - Support media fragments with SVG documents

Status: RESOLVED FIXED

(Core :: SVG, enhancement)

Comment 1

[Robert Longson [:longsonr]]

Attachment: Bug 1999989 Part 1 - Rename, move and export MediaFragmentURIParser r=emilio

Comment 2

[Robert Longson [:longsonr]]

Attachment: Bug 1999989 Part 2 - refactor SVGAnimatedViewBox interface r=emilio

Comment 3

[Robert Longson [:longsonr]]

Attachment: Bug 1999989 Part 3 - SVG media fragment support r=emilio

From https://svgwg.org/svg2-draft/linking.html#SVGFragmentIdentifiers

• If the SVG fragment identifier addresses a space segment (e.g., MyDrawing.svg#xywh=0,0,100,100),then the initial view into the SVG document is established using the view specification attributes on the outermost svg element where the 'viewBox' is overriden by the x, y, width and height values provided by the fragment identifier.

• If the SVG fragment identifier addresses a time segment (e.g., MyDrawing.svg#t=10),then the initial view into the SVG document is established as if no fragment identifier was provided. The rendering of the SVG Document shall be as if the setCurrentTime method on the SVG Document element had been called with the begin time value from the fragment identifier. Additionally, if an end time value is provided in the fragment identifier, the effect is equivalent to calling the pauseAnimations method on the SVG Document when the document time reaches the end time of the fragment identifier.

Comment 4

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=97296056397bad5a857e03d851cff9eb43854a60

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1a8092d3eeea
https://hg.mozilla.org/integration/autoland/rev/2528ce0feb60
Part 1 - Rename, move and export MediaFragmentURIParser r=emilio,necko-reviewers,media-playback-reviewers,karlt,valentin
https://github.com/mozilla-firefox/firefox/commit/747e38c2bb65
https://hg.mozilla.org/integration/autoland/rev/8c5742cd1005
Part 2 - refactor SVGAnimatedViewBox interface r=emilio
https://github.com/mozilla-firefox/firefox/commit/0ab5fc76883d
https://hg.mozilla.org/integration/autoland/rev/a083f2717228
Part 3 - SVG media fragment support r=birtles

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/56116 for changes under testing/web-platform/tests

Comment 7

[amarc]

https://hg.mozilla.org/mozilla-central/rev/2528ce0feb60
https://hg.mozilla.org/mozilla-central/rev/8c5742cd1005
https://hg.mozilla.org/mozilla-central/rev/a083f2717228

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 9

[Robert Longson [:longsonr]]

SVG Documents now work the same as videos i.e. they support media fragment identifiers as defined in https://www.w3.org/TR/media-frags/

• you can play a portion of a SMIL animation from a specific start time to a specific end time (where the animation will pause) via the temporal dimension syntax.

• you can display a specific area of an SVG document via the spatial dimension syntax. This works in a similar way to the existing #svgView(viewBox(x,y,w,h)) syntax

Comment 10

[Chris Mills [:cmills]]

Media fragments documentation now published: https://developer.mozilla.org/en-US/docs/Web/URI/Reference/Fragment/Media_fragments.

Comment 11

[Robert Longson [:longsonr]]

If you've found that spatial values work unreliably with percentages maybe you could raise a new bug with an example of the issue.

Comment 12

[Chris Mills [:cmills]]

(In reply to Robert Longson [:longsonr] from comment #11)

If you've found that spatial values work unreliably with percentages maybe you could raise a new bug with an example of the issue.

Thanks for bringing this up, Robert. I should have explored this further with you before publishing.

This might be due to my misunderstanding of how the spatial syntax % values should be used, but when testing them, I was unable to get it to work as I'd expect. I'll give you a couple of examples, and you can tell me whether it is worth filing a separate bug.

If I:

1. Go to the example at https://developer.mozilla.org/en-US/docs/Web/URI/Reference/Fragment/Media_fragments#displaying_a_subset_of_an_svg_image.
2. Modify the src attribute of the <img> element to src="/shared-assets/images/examples/firefox-logo.svg#xywh=percent:0,0,50,50".

I would expect the image displayed to be the top-left quarter of the Firefox logo. But it isn't. It seems to display a tiny fraction of it. In fact, if you test it on the raw image displayed in a browser tab, it seems to display nothing: https://bef81064f6f7ee9660c9e8b81a0b2c12a080bab7.mdnplay.dev/shared-assets/images/examples/firefox-logo.svg#xywh=percent:0,0,50,50

If I change the fragment to #xywh=percent:0,0,100,100, I'd expect it to display the entire image (top corner = 0%,0%, width and height 100%), but it doesn't: https://bef81064f6f7ee9660c9e8b81a0b2c12a080bab7.mdnplay.dev/shared-assets/images/examples/firefox-logo.svg#xywh=percent:0,0,100,100.