1999997 - Allow to add rule for pseudo element nodes

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

We disable the add rule button if the selected element is a anonymous node https://searchfox.org/firefox-main/rev/4fd0fa7e5814c0b51f1dd075821988377bc56cc1/devtools/client/inspector/rules/rules.js#770-771,774-775

refreshAddRuleButtonState() {
  const shouldBeDisabled =
...
    this.inspector.selection.isAnonymousNode();
  this.addRuleButton.disabled = shouldBeDisabled;

this means that you can't add a rule for ::before or ::view-transition nodes
we should allow it

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1999997 - [devtools] Allow to add rule on pseudo elements. r=#devtools.

In addNewRule, we retrieve the binding element and pseudo from the passed node,
and if it is a pseudo element, we append the pseudo element type at the end of
the selector.
Tests are updated to check the new behavior.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ac33ad716c68
https://hg.mozilla.org/integration/autoland/rev/ab12ae338ab0
[devtools] Allow to add rule on pseudo elements. r=devtools-reviewers,jdescottes.

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/ab12ae338ab0

Comment 4

[Sebastian Zartner [:sebo]]

This should be mentioned together with the feature of bug 1998704 in the Firefox 147 dev release notes.

Sebastian