2000150 - "Add class" button (.cls) should be disabled when a class can't be added to the selected node

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

The button should be disabled for:

• doctype
• text node
• comment node
• document / root node
• pseudo element

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

this is the button we should disable https://searchfox.org/firefox-main/rev/c82adde571c24d89da3ef13f11245c8f572ba1e6/devtools/client/inspector/rules/rules.js#196

this.classToggle = doc.getElementById("class-panel-toggle");

we could do something similar to what we do for the "Add Rule" button https://searchfox.org/firefox-main/rev/c82adde571c24d89da3ef13f11245c8f572ba1e6/devtools/client/inspector/rules/rules.js#767-776

/**
 * Disables add rule button when needed
 */
refreshAddRuleButtonState() {
  const shouldBeDisabled =
    !this._viewedElement ||
    !this.inspector.selection.isElementNode() ||
    this.inspector.selection.isAnonymousNode();
  this.addRuleButton.disabled = shouldBeDisabled;
},

Some tests should be added to https://searchfox.org/firefox-main/rev/c82adde571c24d89da3ef13f11245c8f572ba1e6/devtools/client/inspector/rules/test/browser_rules_class_panel_toggle.js

Comment 2

[Areeba]

Hi, I would like to work this on this bug

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Areeba from comment #2)

Hi, I would like to work this on this bug

Hello Areeba, and thanks for offering help!
The bug is now assigned to you

You can follow https://firefox-source-docs.mozilla.org/setup/index.html#getting-set-up-to-work-on-the-firefox-codebase to setup the work environment.
Let me know if you have any questions!

Comment 4

[BugBot [:suhaib / :marco]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Comment 5

[mehdiakiki]

Hello, I would like to work on this Nicolas!
Mehdi

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

(In reply to mehdiakiki from comment #5)

Hello, I would like to work on this Nicolas!
Mehdi

Hello mehdiakiki, the bug is now yours :)
Let me know if you have any question

Comment 7

[BugBot [:suhaib / :marco]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Comment 8

[pullmana8]

Hi there Nicolas

I would like to work on this bug.

I am aware of the build process, so I should have that setup in no time to take a look and work on this issue.

Thanks!

Antonette

Comment 9

[pullmana8]

Attachment: Bug 2000150 - Disable .cls toggle for invalid selected nodes in Rules view. r?#devtools-reviewers

Comment 10

[BugBot [:suhaib / :marco]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Comment 11

[Gopalarathnam Venkatesan]

Attachment: Bug 2000150 - Disable .cls panel inputs when a class cannot be added to the selected node r=jdescottes

When the selected node is a pseudo element, a text node or DOCTYPE, the inputs within
the class panel are disabled instead of disabling the ".cls" button itself. The behavior
is very much like how it's done with the ":hov" button.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c8d8dd33b265
https://hg.mozilla.org/integration/autoland/rev/ecfe307aebc1
Disable .cls panel inputs when a class cannot be added to the selected node r=devtools-reviewers,jdescottes

Comment 13

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ecfe307aebc1