2000240 - avoid printing 'undefined assertion name' for assertions outsides of test tasks

Status: RESOLVED FIXED

(Testing :: Mochitest, task)

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 2000240 - avoid printing 'undefined assertion name' for assertions outsides of test tasks, r=ahal.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2217a43137a5
https://hg.mozilla.org/integration/autoland/rev/fa25b1f1912b
avoid printing 'undefined assertion name' for assertions outsides of test tasks, r=ahal.

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/fa25b1f1912b

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/441715a778a7
https://hg.mozilla.org/integration/autoland/rev/0f79b6f3330a
Revert "Bug 2000240 - avoid printing 'undefined assertion name' for assertions outsides of test tasks, r=ahal." for "Too few arguments" logged.

Comment 5

[Iulian Moraru]

This was backed out from autoland for "Too few arguments" logged. - Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/0f79b6f3330a1c094c5a9030256ce85c49f96160

Comment 6

[amarc]

backout merged to central: https://hg.mozilla.org/mozilla-central/rev/0f79b6f3330a

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/28417f546639
https://hg.mozilla.org/integration/autoland/rev/faf1108d60ba
avoid printing 'undefined assertion name' for assertions outsides of test tasks, r=ahal.

Comment 8

[Alex Finder]

(In reply to Pulsebot from comment #2)

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2217a43137a5
https://hg.mozilla.org/integration/autoland/rev/fa25b1f1912b
avoid printing 'undefined assertion name' for assertions outsides of test
tasks, r=ahal.

Perfherder has detected a browsertime performance change from push fa25b1f1912baf12b3f9e782ccaaa8275bbc4d37.

No action is required from the author; this comment is provided for informational purposes only.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
2%	facebook-nav.landing fcp	linux1804-64-shippable-qr	cold fission webrender	860.43 -> 843.18

Need Help or Information?

If you have any questions, please reach out to [e-mail]. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

Comment 9

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/faf1108d60ba