Closed Bug 2000263 Opened 1 month ago Closed 1 month ago

User-customized font weight in Reader View isn't working anymore

Categories

(Toolkit :: Reader Mode, defect, P1)

Product:
Toolkit
Component:
Reader Mode
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
147 Branch
Tracking Flags:
Tracking Status
firefox-esr115 --- unaffected
firefox-esr140 --- unaffected
firefox145 --- unaffected
firefox146 --- verified
firefox147 --- verified

People

(Reporter: ini, Assigned: ini)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Bug 2000263 - Restore font weight controls in Reader View. r=#reader-mode-reviewers
48 bytes, text/x-phabricator-request
Details | Review
Bug 2000263 - Restore font weight controls in Reader View.
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-beta+
Details | Review

Bug 1992736 replaced the --font-weight CSS variable that was used to customize font weight via the dropdown selector. We want to replace the token to restore this functionality.

Assignee: nobody → ini
Status: NEW → ASSIGNED
Keywords: regression
Regressed by: 1992736
OS: Unspecified → All
Hardware: Unspecified → Desktop
status-firefox145: --- → unaffected
status-firefox-esr115: --- → unaffected
status-firefox-esr140: --- → unaffected
Summary: Restore font weight controls in Reader View → User-customized font weight in Reader View isn't working anymore
Pushed by gijskruitbosch@gmail.com: https://github.com/mozilla-firefox/firefox/commit/ca57aa6af2e9 https://hg.mozilla.org/integration/autoland/rev/62b32470582a Restore font weight controls in Reader View. r=reader-mode-reviewers,desktop-theme-reviewers,Itiel

https://hg.mozilla.org/mozilla-central/rev/62b32470582a

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox147: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 147 Branch

The patch landed in nightly and beta is affected.
:ini, is this bug important enough to require an uplift?

For more information, please visit BugBot documentation.

Flags: needinfo?(ini)
Attachment #9527577 - Flags: approval-mozilla-beta?

Uplift requested.

Flags: needinfo?(ini)

firefox-beta Uplift Approval Request

  • User impact if declined: fixing a regression to a core function of Reader View customize menu
  • Code covered by automated testing: yes
  • Fix verified in Nightly: no
  • Needs manual QE test: yes
  • Steps to reproduce for manual QE testing: 1. Visit a text-heavy webpage such as a news article
  1. Click on Reader View icon in address bar (right side page text icon)
  2. Open the text and layout menu (Aa icon)
  3. With Sans-serif font selected, test the font weight dropdown
    Expected: font weights are being applied correctly
  • Risk associated with taking this patch: low
  • Explanation of risk level: CSS only change to a single dropdown
  • String changes made/needed: n/a
  • Is Android affected?: no
Flags: qe-verify+
QA Whiteboard: [uplift] [qa-ver-needed-c147/b146]

Verified fixed using 147.0a1 (20251119095727) on WIndows 10, MacOS 15.5 and Ubuntu 24.04.

status-firefox147: fixed → verified
QA Contact: pmagyari
Attachment #9527577 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified fixed using Firefox 146.0b6 (20251121110812).

Status: RESOLVED → VERIFIED
QA Whiteboard: [uplift] [qa-ver-needed-c147/b146] → [uplift] [qa-ver-done-c147/b146]
status-firefox146: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: