Closed Bug 2000283 Opened 1 year ago Closed 9 months ago

sync-about-blank: EndExecutionTracingAsync runnable leaks

Categories

(Core :: Gecko Profiler, defect, P3)

defect

Tracking

()

RESOLVED FIXED
149 Branch
Tracking Status
firefox149 --- fixed

People

(Reporter: vhilla, Assigned: alexical)

References

Details

Attachments

(1 file, 1 external file)

Attached file browser_test_leak.js —

This is a bug for a leak that only occurs with the WIP patch in bug 543435. To get that patch landed, I'm considering adding a timeout to the test and addressing the leak in a follow-up.

Bug 1959977 recently landed tools/profiler/tests/browser/browser_test_feature_js_sourceindex.js. With the sync-about-blank patch, this test frequently leaks the runnable from CycleCollectedJSContext::EndExecutionTracingAsync. The runnable is dispatched during shutdown and never executes.

I reduced the test case to the attached code. Maybe the profiler of the first tab isn't shut down completely before the second tab creates it's initial about:blank? Given the specific circumstances where this occurs, I hope this doesn't block landing the patch.

See Also: → 1959977, sync-about-blank

The severity field is not set for this bug.
:canova, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(canaltinova)

Hey Alex, do you have any idea why this migh be happening?

Flags: needinfo?(canaltinova) → needinfo?(dothayer)
Severity: -- → S3
Priority: -- → P3
Assignee: nobody → dothayer
Flags: needinfo?(dothayer)

When we're on the context's thread, there's no good reason to begin/end
execution tracing async. We should just do so synchronously.

Pushed by dothayer@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/515a4a0586b9 https://hg.mozilla.org/integration/autoland/rev/a5d0ee14d5bc Synchronously begin/end execution tracing when okay r=canaltinova,profiler-reviewers
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 149 Branch
QA Whiteboard: [qa-triage-done-c150/b149]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: