sync-about-blank: EndExecutionTracingAsync runnable leaks
Categories
(Core :: Gecko Profiler, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox149 | --- | fixed |
People
(Reporter: vhilla, Assigned: alexical)
References
Details
Attachments
(1 file, 1 external file)
|
1.22 KB,
application/x-javascript
|
Details |
This is a bug for a leak that only occurs with the WIP patch in bug 543435. To get that patch landed, I'm considering adding a timeout to the test and addressing the leak in a follow-up.
Bug 1959977 recently landed tools/profiler/tests/browser/browser_test_feature_js_sourceindex.js. With the sync-about-blank patch, this test frequently leaks the runnable from CycleCollectedJSContext::EndExecutionTracingAsync. The runnable is dispatched during shutdown and never executes.
I reduced the test case to the attached code. Maybe the profiler of the first tab isn't shut down completely before the second tab creates it's initial about:blank? Given the specific circumstances where this occurs, I hope this doesn't block landing the patch.
| Reporter | ||
Updated•1 year ago
|
Comment 1•11 months ago
|
||
The severity field is not set for this bug.
:canova, could you have a look please?
For more information, please visit BugBot documentation.
Comment 2•10 months ago
|
||
Hey Alex, do you have any idea why this migh be happening?
Updated•10 months ago
|
| Assignee | ||
Updated•9 months ago
|
| Assignee | ||
Comment 3•9 months ago
|
||
When we're on the context's thread, there's no good reason to begin/end
execution tracing async. We should just do so synchronously.
Updated•8 months ago
|
Description
•