Closed Bug 2000365 Opened 7 months ago Closed 6 months ago

Remove accessibility.browsewithcaret_shortcut.enabled pref from GeckoView

Categories

(GeckoView :: General, task, P3)

All
Android
task

Tracking

(firefox147 fixed)

RESOLVED FIXED
147 Branch
Tracking Status
firefox147 --- fixed

People

(Reporter: gregp, Assigned: liu.c.ashley)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

Attachments

(1 file)

In bug 1629113, the caret browsing handler was moved to browser/base/content/tabbrowser.js, resulting in this pref never being read on Android. To reduce confusion, we can remove it from geckoview-prefs.js

https://searchfox.org/firefox-main/rev/c82adde571c24d89da3ef13f11245c8f572ba1e6/mobile/android/app/geckoview-prefs.js#13-14

Keywords: good-first-bug
Whiteboard: [lang=js]
Severity: -- → N/A
Priority: -- → P3

Hi, my project team is interested in patching this bug. We are first-time contributors, and have read the relevant documentation on contributing. Are there any other documents we should read before we continue? Thanks!

Flags: needinfo?(gregp)

Hi, the relevant documentation you've linked are great resources for starting out. If you have questions, you can ask for help on Matrix in #introduction:mozilla.org

Flags: needinfo?(gregp)
Assignee: nobody → liu.c.ashley
Status: NEW → ASSIGNED
Pushed by tcampbell@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/ee895fbb1fb8 https://hg.mozilla.org/integration/autoland/rev/6549a3c3513b Remove accessibility.browsewithcaret_shortcut.enabled pref from GeckoView. r=gregp,geckoview-reviewers,tcampbell
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 147 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: