2000479 - `ContentCacheInParent::HandleQueryContentEvent` should not return error when there is a selection and queried with relative offset from current selection

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(PTO: 9/19-9/27)]

https://searchfox.org/firefox-main/rev/dada95df62357a983cc45284133b92de35609dd2/widget/ContentCache.cpp#829

    } else if (NS_WARN_IF(mSelection->mHasRange)) {
      MOZ_LOG(sContentCacheLog, LogLevel::Error,
              ("0x%p HandleQueryContentEvent(), FAILED due to there is no "
               "selection range, but the query requested with relative offset "
               "from selection",
               this));
      return false;

Obviously, the check should be NS_WARN_IF(!mSelection->mHasRange)!

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(PTO: 9/19-9/27)]

Attachment: Bug 2000479 - Make `ContentCacheInParent::HandleQueryContentEvent` not stop handling the query when the offset is relative and there is selection r=m_kato!

This is just the typo of the condition, but this have made a lot of
queries failed when there is no IME selections. This could be one of
the cause of bug 1824143.

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1746104

Comment 3

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Chinese users might see the crash of bug 1824143 because this bug caused us returning unexpected error to TSF when TSF/IME queries character rect or text content around selection.

(And this may fix bug 1859125 because we failed to reply queries due to this bug.)

• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Just fix the mistake.
• String changes made/needed: no
• Is Android affected?: no

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(PTO: 9/19-9/27)]

Attachment: Bug 2000479 - Make `ContentCacheInParent::HandleQueryContentEvent` not stop handling the query when the offset is relative and there is selection

This is just the typo of the condition, but this have made a lot of
queries failed when there is no IME selections. This could be one of
the cause of bug 1824143.

Original Revision: https://phabricator.services.mozilla.com/D272821

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4d64217665ac
https://hg.mozilla.org/mozilla-central/rev/3f13262a0a2e
Make `ContentCacheInParent::HandleQueryContentEvent` not stop handling the query when the offset is relative and there is selection r=m_kato

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3f13262a0a2e

Comment 7

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/7bafb4776775
https://hg.mozilla.org/releases/mozilla-beta/rev/530dd7ff73c9

Comment 8

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined: Chinese users cannot use Baidu's search form due to the crash (which may be caused by returning error to TSF caused by bug 1824143, bug 2000479 and bug 1992288) or our TextEditor bug (bug 1992288).

As far as using moz-phab patch on the release branch, these patches can be applied cleanly and the new tests work.
https://treeherder.mozilla.org/jobs?repo=try&revision=cd466c731c4fd16f201ca5f3b6f42ff6ef88aef6
(The bustage of Bp-nu is in media's code...)

• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: 1. Install Sogou IME from https://pinyin.sogou.com/index.php and use it

2. Run debug build on Windows
3. Load https://www.baidu.com/
4. Type "nihao" into the search form at center of the page

Then, you should be able to type text after the form is moved to top of the page and you shouldn't see a lot of warnings in the terminal:

WARNING: 'queryTextRectEvent.Failed()', file D:/firefox2/widget/windows/TSFTextStore.cpp:2020

(The line number may become different after applying the last patch.)

• Risk associated with taking this patch: low
• Explanation of risk level: The first one is just adding the logger of TextEditor creation, etc. So, it does not affect to the behavior.

The second one is covered by the automated test.

The third one makes TSFTextStore stop notifying TSF of "layout available notifiecation" immediately after dispatching composition events. This can be checked by the manual QE testing.

The last one fixes the simple mistake of the content cache in the parent process.

(About "Is Android affected": Only the second bug fix and the last bug fix are cross-platform bugs. Therefore, they are "yes", but the 3rd patch is "no".)

• String changes made/needed: no
• Is Android affected?: yes

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(PTO: 9/19-9/27)]

Attachment: Bug 2000479 - Make `ContentCacheInParent::HandleQueryContentEvent` not stop handling the query when the offset is relative and there is selection

This is just the typo of the condition, but this have made a lot of
queries failed when there is no IME selections. This could be one of
the cause of bug 1824143.

Original Revision: https://phabricator.services.mozilla.com/D272821

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(PTO: 9/19-9/27)]

Attachment: Bug 2000479 - Make `ContentCacheInParent::HandleQueryContentEvent` not stop handling the query when the offset is relative and there is selection

This is just the typo of the condition, but this have made a lot of
queries failed when there is no IME selections. This could be one of
the cause of bug 1824143.

Original Revision: https://phabricator.services.mozilla.com/D272821

Comment 11

[Phabricator Automation]

firefox-esr140 Uplift Approval Request

• User impact if declined: Chinese users cannot use Baidu's search form due to the crash (which may be caused by returning error to TSF caused by bug 1824143, bug 2000479 and bug 1992288) or our TextEditor bug (bug 1992288).
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: 1. Install Sogou IME from https://pinyin.sogou.com/index.php and use it

2. Run debug build on Windows
3. Load https://www.baidu.com/
4. Type "nihao" into the search form at center of the page

Then, you should be able to type text after the form is moved to top of the page and you shouldn't see a lot of warnings in the terminal:

WARNING: 'queryTextRectEvent.Failed()', file D:/firefox2/widget/windows/TSFTextStore.cpp:2020

(The line number may become different after applying the last patch.)

• Risk associated with taking this patch: low
• Explanation of risk level: The first one and the last one are covered by the automated test.

The second one makes TSFTextStore stop notifying TSF of "layout available notifiecation" immediately after dispatching composition events. This can be checked by the manual QE testing.

Note that this does not contain the patch for bug 1824143 because it only adds the logger of TextEditor creation, destruction and focus/blur. However, it's not required to fix the bug but it requires the new logging helper methods which were added in bug 1983375 in 144.

(About "Is Android affected": Only the second bug fix and the last bug fix are cross-platform bugs. Therefore, they are "yes", but the 3rd patch is "no".)

• String changes made/needed: no
• Is Android affected?: yes

Comment 12

[Bogdan Maris, Desktop Test Engineering]

Reproduced the issue described in comment 8 using an old Nightly debug build from 2025-11-17, lots of Warnings with queryTextRectEvent.Failed are displayed.
Verified that using the latest Nightly 147.0a1 debug and Firefox Beta 146 debug build on Windows 11, no more errors appear in the console while typing in baidu.com.
Not closing the bug as verified just yet, waiting for the esr140 uplift.

Comment 13

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/f150513ca1ea
https://hg.mozilla.org/releases/mozilla-release/rev/0324bfb7e808

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr140/rev/67e2d9596fdb

Comment 15

[Ciprian Georgiu, Desktop QA]

This is also verified as fixed on debug builds, Firefox 145.0.2 and 140.6.0esr on Win 11.