2000531 - storage.googleapis.com - Incorrect movement triggered when tapping/clicking on maze

Status: VERIFIED FIXED

(Core :: SVG, defect, P1)

Description

[Raul Bucata]

Environment:
Operating system: Linux and Windows 10
Firefox version: Firefox 140.0

Steps to reproduce:

1. Navigate to: https://storage.googleapis.com/maze-playground/game.html
2. Click on a maze direction and observe

Expected Behavior:
The move is correctly interpreted

Actual Behavior:
The move returned is only up facing direction

Notes:

• Reproduces regardless of the status of ETP
• Reproduces in firefox-nightly, and firefox-release
• Does not reproduce in chrome

Created from https://github.com/webcompat/web-bugs/issues/189202

Comment 1

[Raul Bucata]

Attachment: Chr vs ff

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 3

[Alice0775 White]

Regression window:
https://hg-edge.mozilla.org/integration/autoland/pushloghtml?fromchange=f31868a8422c30fcae5963a72cf8ba9ea9b3816a&tochange=afa1bd505415fcb1854f5198fc29ee834c105482

Comment 4

[Emilio Cobos Álvarez [:emilio]]

The code is here fwiw.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1890198

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

:longsonr, since you are the author of the regressor, bug 1890198, could you take a look?

For more information, please visit BugBot documentation.

Comment 7

[Robert Longson [:longsonr]]

The outer frames transform-box is viewBox
xOffset and yOffset are 16 (bp is 960 in all values)
tm is 83, 0, 0, 83, 150, 10 (approx)
There's no rotation here, just scale and translate.

tm.PreTranslate is 83, 0, 0, 83, 1489, 1348

tm.PostTranslate is 83, 0, 0, 83, 166, 26

I think the right thing is probably to go back to the earlier patch I had in bug 1890198. That seems to work in this case.

Comment 8

[Robert Longson [:longsonr]]

Attachment: Bug 2000531 - Fix getBBox when content has padding and scale r=dholbert

Comment 9

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=79402e6e9fc781c43a4783a0592ac834cd94267f

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7eaee8e028d9
https://hg.mozilla.org/integration/autoland/rev/07d9e2ab9f8e
Fix getBBox when content has padding and scale r=dholbert,firefox-svg-reviewers

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/56178 for changes under testing/web-platform/tests

Comment 12

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/07d9e2ab9f8e

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:longsonr, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox146 to wontfix.

For more information, please visit BugBot documentation.

Comment 15

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: at least one website doesn't work - see comment 0 in the bug.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: follow the steps in comment 0 in the bug.
• Risk associated with taking this patch: low
• Explanation of risk level: more closely matches Chrome's behaviour.
• String changes made/needed: none
• Is Android affected?: yes

Comment 16

[Robert Longson [:longsonr]]

Attachment: Bug 2000531 - Fix getBBox when content has padding and scale

Original Revision: https://phabricator.services.mozilla.com/D273465

Comment 17

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/404f7ee168c6
https://hg.mozilla.org/releases/mozilla-beta/rev/a1c8e3561766

Comment 18

[Peter Magyari (Desktop QA)]

Verified fixed using Nightly 147.0a1 (20251127213532) and Beta 146.0b8 (20251126090434) on MacOS 15, Windows 10 and Ubuntu 24.04.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

Should we uplift this to ESR140 also? Please nominate if yes.

Comment 20

[Ryan VanderMeulen [:RyanVM]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #19)

Should we uplift this to ESR140 also? Please nominate if yes.

Comment 21

[Robert Longson [:longsonr]]

My uplift request failed. I'm afraid I don't know why, or how to fix it. I don't have the ESR cloned and with my current connection it would likely take hours or days to do so.

Comment 22

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 2000531 - Fix getBBox when content has padding and scale

Original Revision: https://phabricator.services.mozilla.com/D273465

Comment 23

[Ryan VanderMeulen [:RyanVM]]

I did the esr140 cherry-pick locally and submitted it to Phab. Not sure what happened with the Lando request there. You should be able to link it to the uplift request you already did for Beta by going to https://lando.moz.tools/D277121/ and clicking on the "Link Existing Assessment" button.

Comment 24

[Phabricator Automation]

firefox-esr140 Uplift Approval Request

• User impact if declined: website in comment 0 is broken.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: checkout the website in comment 0 and follow the instructions.
• Risk associated with taking this patch: low
• Explanation of risk level: should get us closer to Chrome's behaviour.
• String changes made/needed: none
• Is Android affected?: yes

Comment 25

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr140/rev/44404e44d7f9

Comment 26

[Peter Magyari (Desktop QA)]

Verified fixed on ESR 140.7.0 (20251219025910).